fix(models): halt destroy callbacks for datebooks, doctors and admin users - #1131
Open
raulriera wants to merge 1 commit into
Open
fix(models): halt destroy callbacks for datebooks, doctors and admin users#1131raulriera wants to merge 1 commit into
raulriera wants to merge 1 commit into
Conversation
…users Rails 5+ ignores a false return from before_destroy; these guards were inert, so datebooks and doctors with appointments and admin users could be destroyed. Use errors.add + throw :abort, reinstate the commented regression test, and clear appointments in the doctors empty-state test setup so its destroy_all still empties the practice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
before_destroyguards on Datebook, Doctor and User returnedfalse, which no longer halts the callback chain (Rails 5+), so datebooks/doctors with appointments and admin users were silently destroyableerrors.add(:base, ...)+throw :abortdestroy_allso it still empties the practiceTest plan