Document pass-by-reference behavior for large arguments#287
Open
Feoramund wants to merge 1 commit intoodin-lang:masterfrom
Open
Document pass-by-reference behavior for large arguments#287Feoramund wants to merge 1 commit intoodin-lang:masterfrom
Feoramund wants to merge 1 commit intoodin-lang:masterfrom
Conversation
Contributor
|
Good idea. |
gingerBill
reviewed
Nov 5, 2025
| fmt.println(sum(..odds)) // 9, passing a slice as varargs | ||
| ``` | ||
|
|
||
| **Note:** Odin makes a compromise for the sake of performance in that large arguments (as determined by the compiler) are internally passed by reference (as opposed to always copying them to the stack, as C does) and this can have surprising consequences if you are not aware of it. Here's an example: |
Member
There was a problem hiding this comment.
It is now defined as always >16 bytes now. <= 16 bytes will always be "pass by value".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was discussed in odin-lang/Odin#2971 but I couldn't find any mention of it on the overview. I used @jakubtomsu's initial example with expanded names so the problem is more clear.
It would be good if we could get an exact and explicit definition of what is a "large" argument.