-
Notifications
You must be signed in to change notification settings - Fork 85
test variable.dispose #380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Fil
wants to merge
2
commits into
mbostock/variable-dispose
Choose a base branch
from
fil/variable-dispose-tests
base: mbostock/variable-dispose
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,100 @@ | ||
| import { Runtime } from "@observablehq/runtime"; | ||
| import assert from "assert"; | ||
| import { delay, sleep } from "./valueof.js"; | ||
|
|
||
| describe("variable.dispose", () => { | ||
| it("prevents a subsequent delete from notifying the observer", async () => { | ||
| // https://github.com/observablehq/notebook-kit/issues/174 | ||
| const runtime = new Runtime(); | ||
| const main = runtime.module(); | ||
| const log = []; | ||
| const foo = main | ||
| .variable({ fulfilled: (value) => log.push(`a-${value}`) }) | ||
| .define([], () => 1); | ||
| await sleep(); | ||
| foo.dispose(); | ||
| foo.delete(); | ||
| main | ||
| .variable({ fulfilled: (value) => log.push(`b-${value}`) }) | ||
| .define([], () => 2); | ||
| await sleep(); | ||
| assert.deepStrictEqual(log, ["a-1", "b-2"]); // not followed by "a-undefined" | ||
| }); | ||
| it("prevents future computation", async () => { | ||
| const runtime = new Runtime(); | ||
| const main = runtime.module(); | ||
| const log = []; | ||
| const foo = main | ||
| .variable({ fulfilled: (value) => log.push(value) }) | ||
| .define([], () => 1); | ||
| await sleep(); | ||
| foo.dispose(); | ||
| foo.define([], () => 2); | ||
| await sleep(); | ||
| assert.deepStrictEqual(log, [1]); | ||
| }); | ||
| it("cancels an in-flight computation", async () => { | ||
| const runtime = new Runtime(); | ||
| const main = runtime.module(); | ||
| const log = []; | ||
| const foo = main | ||
| .variable({ fulfilled: (value) => log.push(value) }) | ||
| .define([], () => delay(1, 100)); | ||
| await sleep(); | ||
| foo.dispose(); | ||
| await sleep(200); | ||
| assert.deepStrictEqual(log, []); | ||
| }); | ||
| it("invalidates the variable", async () => { | ||
| const runtime = new Runtime(); | ||
| const main = runtime.module(); | ||
| const log = []; | ||
| const foo = main | ||
| .variable(true) | ||
| .define(["invalidation"], async (invalidation) => { | ||
| await invalidation; | ||
| log.push("invalidation"); | ||
| }); | ||
| await sleep(); | ||
| foo.dispose(); | ||
| await sleep(); | ||
| assert.deepStrictEqual(log, ["invalidation"]); | ||
| }); | ||
| it("terminates generators", async () => { | ||
| const runtime = new Runtime(); | ||
| const main = runtime.module(); | ||
| const log = []; | ||
| const foo = main.variable(true).define([], function* () { | ||
| try { | ||
| while (true) yield; | ||
| } finally { | ||
| log.push("return"); | ||
| } | ||
| }); | ||
| await sleep(); | ||
| foo.dispose(); | ||
| await sleep(); | ||
| assert.deepStrictEqual(log, ["return"]); | ||
| }); | ||
| it("terminates async generators", async () => { | ||
| const runtime = new Runtime(); | ||
| const main = runtime.module(); | ||
| const log = []; | ||
| let when = "before"; | ||
| const foo = main.variable(true).define([], async function* () { | ||
| try { | ||
| while (true) { | ||
| await sleep(20); | ||
| yield log.push(when); | ||
| } | ||
| } finally { | ||
| log.push("return"); | ||
| } | ||
| }); | ||
| await sleep(50); // 50ms gives time to log two values | ||
| foo.dispose(); | ||
| when = "after"; | ||
| await sleep(50); // logs one last value and then terminates | ||
| assert.deepStrictEqual(log, ["before", "before", "after", "return"]); | ||
| }); | ||
| }); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.