Skip to content

Fixed: Blockly lights field toggle state resetting on reload. #516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hardikgarg02 wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fixed: Blockly lights field toggle state resetting on reload. #516

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f7e6306
Merge pull request #50 from ob-f/master
sparsh3dwe Feb 25, 2026
2a9744a
Fixed field_toggle state persistence on reload
harishthakur52 Apr 29, 2026
13e2f2d
Merge branch 'ob-f:master' into blockly-field-fixes
hardikgarg02 May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 21 additions & 9 deletions open-code/src/components/blockly/blocks/field_toggle.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,15 +7,14 @@ export class FieldToggle extends Blockly.Field {
constructor(state, onText, offText, opt_validator) {
super('', opt_validator);
this.state_ = state;
this.onText_ = onText;
this.offText_ = offText;
this.onText_ = onText || "ON";
this.offText_ = offText || "OFF";
this.SERIALIZABLE = true;
}
init() {
super.init();
Blockly.Tooltip.bindMouseEvents(this.fieldGroup_);
this.setValue(this.state_);
this.showEditor_();
this.fieldGroup_.classList.add('blocklyFieldToggle');
}

Expand All @@ -29,19 +28,31 @@ export class FieldToggle extends Blockly.Field {

//set the text value to the selected state
setValue(newValue) {
this.state_ = !!newValue;
const text = this.state_ ? this.onText_ : this.offText_;
const onText = this.onText_ || "ON";
const offText = this.offText_ || "OFF";

if (typeof newValue === "string") {
const normalized = newValue.trim().toUpperCase();
this.state_ = normalized === onText.toUpperCase();
} else {
this.state_ = !!newValue;
}
const text = this.state_ ? onText : offText;
super.setValue(text);
this.updateDisplay_();
}

//update the value of state after clicking on element
updateDisplay_() {
if (this.textElement_) {
this.textElement_.firstChild.nodeValue = this.state_ ? this.onText_ : this.offText_;
const rectElement = this.fieldGroup_.querySelector('rect');
rectElement.classList.toggle('field-toggle-on', this.state_);
rectElement.classList.toggle('field-toggle-off', !this.state_);
const onText = this.onText_ || "ON";
const offText = this.offText_ || "OFF";
this.textElement_.firstChild.nodeValue = this.state_ ? onText : offText;
const rectElement = this.fieldGroup_?.querySelector('rect');
if (rectElement) {
rectElement.classList.toggle('field-toggle-on', this.state_);
rectElement.classList.toggle('field-toggle-off', !this.state_);
}
}
}

Expand All @@ -57,3 +68,4 @@ Blockly.fieldRegistry.register('field_toggle', FieldToggle);