Skip to content

Interactive waiting jobs with lost session should be killed (#143)#144

Merged
bzizou merged 1 commit into
masterfrom
lost_session
Jun 15, 2026
Merged

Interactive waiting jobs with lost session should be killed (#143)#144
bzizou merged 1 commit into
masterfrom
lost_session

Conversation

@bzizou

@bzizou bzizou commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Proposed fix for #143

@oar-team oar-team deleted a comment from codecov Bot Jun 12, 2026
@bzizou bzizou self-assigned this Jun 12, 2026
@bzizou bzizou requested a review from augu5te June 12, 2026 08:56
@codecov

codecov Bot commented Jun 12, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 20.00000% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 77.24%. Comparing base (ddceb31) to head (6419d31).

Files with missing lines Patch % Lines
oar/kao/meta_sched.py 20.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
- Coverage   77.27%   77.24%   -0.04%     
==========================================
  Files          79       79              
  Lines        9815     9819       +4     
  Branches     1968     1969       +1     
==========================================
  Hits         7585     7585              
- Misses       1603     1606       +3     
- Partials      627      628       +1     
Flag Coverage Δ
unittests 77.24% <20.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@augu5te

augu5te commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

All seems good for me

@bzizou bzizou merged commit c094da6 into master Jun 15, 2026
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants