Skip to content

prefix based matching to query filter values displayed using dropdown - #115

Merged
dakshshahani merged 5 commits into
devfrom
daksh/query-dropdowns
Jul 24, 2026
Merged

prefix based matching to query filter values displayed using dropdown#115
dakshshahani merged 5 commits into
devfrom
daksh/query-dropdowns

Conversation

@dakshshahani

Copy link
Copy Markdown
Collaborator
  • new component ui/combobox.tsx added – reusable free-text input + anchored dropdown, consists prefix narrowing functionality
  • categorical column metadata collected – columns subcategorized as categorical and multi-value columns. extractColumnValues collects distinct columns values. used with existing QueryProvider, updating column data with page refresh (activeHackathon change etc). no extra firestore reads :D
  • types and integration — updated queryFilters.tsx andfilter-rows.tsx to use combobox.tsx for boolean and categorical variables. works with the existing edit-filter-in-place flow and shares the same newFilterValue state.

@dakshshahani
dakshshahani requested review from Copilot and geoff-jiang and removed request for Copilot July 22, 2026 22:45
@github-actions

github-actions Bot commented Jul 22, 2026

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit bd81868):

https://dev-nwplus-admin--pr115-30053769960-2r5sanoe.web.app

(expires Sun, 02 Aug 2026 23:38:28 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: c290bf9e2fac0401389f751f415cce4267517b51

@geoff-jiang

Copy link
Copy Markdown
Contributor

@dakshshahani Simply lovely.

side note: the 'matches' option behaves more like 'contains' since it will return all rows that pass the filter even if there are other multi-select values.
eg. The filter 'gender matches male' will return a row where gender contains 'male, unsure'.

What do you think about changing the matches label to instead be 'contains' and equals to be 'exactly equals'? Might be clearer for organizers.

@dakshshahani

Copy link
Copy Markdown
Collaborator Author
donotsharethis-gif

good idea, i'll add change matches → contains and equals → exactly equals

@dakshshahani
dakshshahani merged commit 0f800ae into dev Jul 24, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants