prefix based matching to query filter values displayed using dropdown - #115
Merged
Conversation
dakshshahani
requested review from
Copilot and
geoff-jiang
and removed request for
Copilot
July 22, 2026 22:45
|
Visit the preview URL for this PR (updated for commit bd81868): https://dev-nwplus-admin--pr115-30053769960-2r5sanoe.web.app (expires Sun, 02 Aug 2026 23:38:28 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: c290bf9e2fac0401389f751f415cce4267517b51 |
Contributor
|
@dakshshahani Simply lovely. side note: the 'matches' option behaves more like 'contains' since it will return all rows that pass the filter even if there are other multi-select values. What do you think about changing the matches label to instead be 'contains' and equals to be 'exactly equals'? Might be clearer for organizers. |
geoff-jiang
approved these changes
Jul 23, 2026
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

ui/combobox.tsxadded – reusable free-text input + anchored dropdown, consists prefix narrowing functionalityextractColumnValuescollects distinct columns values. used with existingQueryProvider, updating column data with page refresh (activeHackathon change etc). no extra firestore reads :DqueryFilters.tsxandfilter-rows.tsxto usecombobox.tsxfor boolean and categorical variables. works with the existing edit-filter-in-place flow and shares the same newFilterValue state.