Clean up config logging

[seanbudd]

Link to issue number:

None

Summary of the issue:

nvda would log the config at info level when a profile upgrade fails. Config should only ever be logged at debug level

Description of user facing changes:

none

Description of developer facing changes:

safer logging

Description of development approach:

• Added a new static method _shouldLogConfigAtStartup to encapsulate the logic for determining whether to log configuration details at startup, improving code readability and maintainability.
• Updated _loadConfig to use the new helper method when logging information when failing to upgrade a profile

Testing strategy:

manual testing

Known issues with pull request:

• log.debug will never get logged during initialization, meaning there is no easy way to decide whether or not to log config when it fails to load.

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.

[seanbudd]

Blocking on the more useful #19966 while we decide what the behaviour should be here