Conversation
|
I think we should either wait until 2026.1 has been released, or retarget this at 2026.1 (likely safe, but it is quite late in the beta cycle). Having different patch versions on beta and master is painful as Python only natively supports machines having one patch version per minor version per architecture installed. |
Sounds good. It's up to you whether to merge this PR. I'm just doing what I can. |
There was a problem hiding this comment.
Pull request overview
Updates the project’s pinned Python version from 3.13.12 to 3.13.13 to pick up the latest patch/security fixes across CI and developer tooling documentation.
Changes:
- Bump CI/CD workflow Python version pins to 3.13.13.
- Update repository Python version pin files used by tooling/build steps.
- Update developer documentation and the user-facing changelog entry to reflect 3.13.13.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
.github/workflows/testAndPublish.yml |
Updates CI matrix/default Python version to 3.13.13. |
.python-versions |
Updates the pinned CPython build identifier to 3.13.13 (x86_64). |
runtime-builders/synthDriverHost32/.python-version |
Updates the synthDriverHost32 runtime builder’s pinned CPython build identifier to 3.13.13 (x86). |
projectDocs/dev/createDevEnvironment.md |
Updates the documented required Python version to 3.13.13. |
user_docs/en/changes.md |
Updates the “Updated components” changelog entry to 3.13.13. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| defaultPythonVersion: '3.13.13' | ||
| supportedPythonVersions: '["3.13.13"]' |
There was a problem hiding this comment.
Pinning defaultPythonVersion/supportedPythonVersions to 3.13.13 will cause this workflow to fail until actions/setup-python provides that exact patch release (which the PR description notes is currently not supported). If you need to land this change before setup-python updates, consider loosening the version passed to setup-python (e.g. target the 3.13 line) or decoupling the version used by setup-python from the patch version used to construct the uv CPython identifier.
| defaultPythonVersion: '3.13.13' | |
| supportedPythonVersions: '["3.13.13"]' | |
| defaultPythonVersion: '3.13' | |
| supportedPythonVersions: '["3.13"]' |
| defaultPythonVersion: '3.13.13' | ||
| supportedPythonVersions: '["3.13.13"]' |
There was a problem hiding this comment.
This PR updates CI/CD here to 3.13.13, but there is still at least one other workflow that pins Python to 3.13.12 (.github/workflows/fetch-crowdin-translations.yml:47). To avoid divergence (and to ensure all automation benefits from the security update), consider updating the remaining workflow(s) or centralizing the Python version so all workflows stay in sync.
Link to issue number:
We need to wait for
actions/setup-python
to update its support for Python 3.13.13 before we can review and merge this PR.
Summary of the issue:
Upgrade Python from 3.13.12 to 3.13.13 to include the latest security fixes.
Description of user facing changes:
none
Description of developer facing changes:
I have updated the following files respectively:
.github/workflows/testAndPublish.yml
.python-versions
projectDocs/dev/createDevEnvironment.md
runtime-builders/synthDriverHost32/.python-version
Please note that user_docs/en/changes.md will be updated at the very end.
Description of development approach:
Description of development approach:
I have updated the following files respectively:
.github/workflows/testAndPublish.yml
.python-versions
projectDocs/dev/createDevEnvironment.md
runtime-builders/synthDriverHost32/.python-version
Please note that user_docs/en/changes.md will be updated at the very end.
Testing strategy:
We need to verify if the CI/CD pipeline builds successfully.
Known issues with pull request:
none
Code Review Checklist: