Proof of concept: Hyphenate Braille using pyphen#19916
Draft
LeonarddeR wants to merge 11 commits intonvaccess:masterfrom
Draft
Proof of concept: Hyphenate Braille using pyphen#19916LeonarddeR wants to merge 11 commits intonvaccess:masterfrom
LeonarddeR wants to merge 11 commits intonvaccess:masterfrom
Conversation
…tation Agent-Logs-Url: https://github.com/LeonarddeR/nvda/sessions/3c0c92ab-c024-44d3-bd6a-c7d6c3a92364 Co-authored-by: LeonarddeR <3049216+LeonarddeR@users.noreply.github.com>
Contributor
|
Once the Chinese word segmentation PR is merged, will it be possible to use its rules to handle Chinese line breaks within this new text wrap framework |
Collaborator
Author
|
I have no idea honestly. That is something we'd need to find out after that is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Closes #17010
Summary of the issue:
Word wrap is sometimes pretty aggressive, especially on shorter braille displays.
Description of user facing changes:
This pull request introduces significant enhancements to braille text wrapping and language management in the braille buffer, along with related configuration and compatibility improvements. The main changes include the addition of a more flexible text wrapping configuration for braille output, support for hyphenation based on language and improved handling of language changes within braille regions.
There are mainly two additional options to choose from:
Description of developer facing changes:
None
Description of development approach:
Braille text wrapping and hyphenation:
BrailleTextWrapenum with options for off, continuation mark only, word boundaries, and hyphenation, replacing the previous booleanwordWrapsetting. Updated the configuration spec and UI strings accordingly.pyphenlibrary and language-aware hyphenation logic. This allows words to be split across lines with proper hyphenation based on the detected language.Language management in braille regions:
Configuration and backward compatibility:
wordWrapsetting to the newtextWrapenum, ensuring backward compatibility and providing deprecation warnings when the old setting is used.Testing strategy:
T.b.d.
Known issues with pull request:
Since this is a proof of concept, there are several major open issues:
Code Review Checklist: