Magnifier reworks#19810
Closed
Boumtchack wants to merge 3 commits intonvaccess:masterfrom
Closed
Conversation
This was referenced Mar 18, 2026
…magnifierReworks
Member
|
Hi @Boumtchack - this PR has already aggregated a lot of changes. Can you consider making each of these refactors done individually via smaller PRs? It makes the whole process much faster |
This was referenced Mar 31, 2026
seanbudd
pushed a commit
that referenced
this pull request
Apr 28, 2026
pre - #19473 parts of #19810 Summary of the issue: #19810 was still to big so I focused on types changes and some functions renaming to go accordingly. All these changes are nescessary for futur magnifier implementations. Description of user facing changes: "default"s have been removed so it can be seen in the doc Description of developer facing changes: replaced MagnifierPosition with MagnifierParameters for better handling of size, place and filter of the magnifier. added a MagnifierType to handle magnifiers different types. Description of development approach: This work was split out from PR #19473 to make review and integration easier. We first added the new structure: MagnifierParameters for size/position/filter, and MagnifierType for futur mode switching.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Link to issue number:
pre - #19473
Summary of the issue:
the #19473 pull request was too big and adds some deep changes to the code, for a smoother incorporation these changes will but moved here
Description of user facing changes:
settings are changed by gestures
new setting page with placeholder for new magnifier modes
added a gesture to change magnifier type
Description of developer facing changes:
replaced
MagnifierPositionwithMagnifierParametersfor better handling of size, place and filter of the magnifier.added a
MagnifierTypeto handle magnifiers different types.added gesture to cycle through magnifier types
Fullscreen/Fixed/Docked/Lens.For know as no new magnifier types is implemented, a
PlaceholderMagnifieras been in order to test gestures and will be replaced by new types in futureDescription of development approach:
This work was split out from PR #19473 to make review and integration easier.
We first added the new structure: MagnifierParameters for size/position/filter, and MagnifierType for mode switching.
A PlaceholderMagnifier is used for now to test settings and gestures safely.
Real modes (Fullscreen, Fixed, Docked, Lens) will be added in later PRs.
Testing strategy:
manual
Known issues with pull request:
Code Review Checklist: