Merge master into try-chineseWordSegmentation-staging

.gitattributes

@@ -4,8 +4,7 @@
 # https://mail.gnome.org/archives/kupfer-list/2010-June/msg00002.html
 *.po filter=cleanpo
 
-eol=lf
-*	text=auto
+* text=auto eol=lf
 
 # Files which should not be renormalized
 *.dic   -text

.github/ISSUE_TEMPLATE/05-addon_integration_request.yaml

@@ -0,0 +1,108 @@
+name: "Feature from Add-on"
+description: "Propose specific functionality from an existing community add-on for integration into NVDA."
+title: "[Feature from Add-on] <Briefly describe the functionality>"
+labels: ["enhancement", "Addon/integration"]
+
+body:
+  - type: markdown
+    attributes:
+      value: |
+        This template is for proposing that a specific feature from an existing community add-on be integrated into NVDA.
+        Please focus your request on a single, conceptually focused piece of functionality.
+        Requests to "integrate this entire add-on" will be closed if the add-on provides many unrelated features.
+        The goal is to identify functionality that is essential for the core user experience.
+
+        Please read [our guide](https://github.com/nvaccess/nvda/blob/master/projectDocs/issues/githubIssueTemplateExplanationAndExamples.md) on how to fill in this template, including how to provide the required files.
+        Issues may be closed if the required information is not present.
+
+        Please also note that the NVDA project has a [Citizen and Contributor Code of Conduct](https://github.com/nvaccess/nvda/blob/master/CODE_OF_CONDUCT.md).
+        NV Access expects that all contributors and other community members read and abide by the rules set out in this document while participating or contributing to this project.
+        This includes creating or commenting on issues and pull requests.
+
+  - type: textarea
+    id: specific-feature
+    attributes:
+      label: "Describe the specific functionality to be integrated"
+      description: |
+        Clearly and concisely describe the feature you are requesting.
+        If the add-on has multiple features, please list only the specific ones you believe are essential for inclusion in NVDA.
+      placeholder: "e.g. 'Add a hotkey to announce the title of the current tab in web browsers.'"
+    validations:
+      required: true
+
+  - type: textarea
+    id: problem-and-impact
+    attributes:
+      label: "What problem does this functionality solve?"
+      description: |
+        Help us understand the benefit of this feature for users.
+
+        * What common user task becomes easier or possible with this feature?
+        * Who is the primary target audience for this functionality (e.g. all users, developers, users of a specific application)?
+        * How does this improve upon NVDA's existing behavior?
+      placeholder: "Describe the problem solved and the target users."
+    validations:
+      required: true
+
+  - type: textarea
+    id: core-justification
+    attributes:
+      label: "Why should this be in NVDA vs. remaining an add-on?"
+      description: "Justify why this functionality is fundamental enough to be included in NVDA by default for all users, rather than being an optional installation."
+      placeholder: "e.g., 'This functionality is critical for accessibility in application XYZ, which is widely used and shouldn't require users to find and install a separate add-on.'"
+    validations:
+      required: true
+
+  - type: markdown
+    attributes:
+      value: |
+        ---
+        ### Source Add-on Information
+        Please provide details about the add-on where this feature is currently implemented.
+
+  - type: input
+    id: add-on-name
+    attributes:
+      label: "Name of the source add-on"
+      description: "The official name of the add-on that currently provides this functionality."
+      placeholder: "e.g. Awesome App Support"
+    validations:
+      required: true
+
+  - type: input
+    id: add-on-link
+    attributes:
+      label: "Link to add-on repository or website"
+      description: "Where can we find the source code and license for this add-on?"
+      placeholder: "https://github.com/user/add-on-repo"
+    validations:
+      required: true
+
+  - type: input
+    id: add-on-maintainers
+    attributes:
+      label: "Current maintainer(s) of the add-on"
+      description: "Please provide the GitHub username or name of the current maintainer, if known."
+      placeholder: "@username or 'Name'"
+    validations:
+      required: false
+
+  - type: dropdown
+    id: license
+    attributes:
+      label: "Add-on License Status"
+      description: "NVDA is licensed under GPL-2.0 or later. To be included, the add-on's code must be available under these terms. Please specify the add-on's current license situation."
+      options:
+        - "GPL-2.0 or later (No relicensing needed)"
+        - "Other GPL-compatible license (Author has agreed to relicense)"
+        - "Other GPL-compatible license (Relicensing permission is not yet confirmed)"
+        - "I don't know / Needs investigation"
+    validations:
+      required: true
+
+  - type: textarea
+    id: additional-context
+    attributes:
+      label: "Additional context"
+      description: "Please provide any other information you believe is relevant, such as dependencies, potential conflicts or other add-ons with similar functionality."
+      placeholder: "Any other details that might help us."

.github/ISSUE_TEMPLATE/15-addon_integration_request.md

@@ -0,0 +1,19 @@
+---
+name: "(Advanced) Feature from add-on"
+about: "Free text feature request template for those familiar with GitHub."
+labels: ["enhancement", "Addon/integration"]
+---
+
+### Describe the specific functionality to be integrated
+
+### What problem does this functionality solve?
+
+### Why should this be in NVDA vs. remaining an add-on?
+
+### Source Add-on Information
+* **Name of the source add-on:**
+* **Link to add-on repository or website:**
+* **Current maintainer(s) of the add-on:**
+* **Add-on license:**
+
+### Additional context

.github/workflows/assign-milestone-on-close.yml

@@ -10,11 +10,23 @@ on:
 permissions:
   issues: write
   pull-requests: write
+  actions: write
 
 jobs:
   assign-milestone:
     runs-on: ubuntu-latest
     steps:
+      - name: Early exit
+        run: |
+          if [ -z "$MILESTONE_ID" ]; then
+            echo "MILESTONE_ID is not set. Exiting workflow."
+            gh run cancel ${{ github.run_id }}
+            gh run watch ${{ github.run_id }}
+          fi
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+          GH_REPO: ${{ github.repository }}
+
       - name: Check if milestone is set
         id: check-milestone
         uses: actions/github-script@v7

.github/workflows/fetch-crowdin-translations.yml

@@ -18,10 +18,22 @@ jobs:
     permissions:
       contents: write
       pull-requests: write
+      actions: write
     env:
       branchName: updateCrowdinTranslations${{ github.run_id }}
 
     steps:
+    - name: Early exit
+      run: |
+        if ("${{ vars.CROWDIN_PROJECT_ID }}".length -eq 0) {
+          Write-Output "CROWDIN_PROJECT_ID is not set. Exiting workflow."
+          gh run cancel ${{ github.run_id }}
+          gh run watch ${{ github.run_id }}
+        }
+      env:
+        GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        GH_REPO: ${{ github.repository }}
+
     - name: Checkout repository
       uses: actions/checkout@v4
       with:
@@ -30,10 +42,10 @@ jobs:
         submodules: true
 
     - name: Set up python
-      uses: actions/setup-python@v5
+      uses: actions/setup-python@v6
       with:
-        python-version: '3.13'
-        architecture: 'x86'
+        python-version: '3.13.12'
+        architecture: 'x64'
 
     - name: setup uv
       uses: astral-sh/setup-uv@v6
@@ -44,51 +56,61 @@ jobs:
         crowdinProjectID: ${{ vars.CROWDIN_PROJECT_ID }}
         crowdinAuthToken: ${{ secrets.CROWDIN_AUTH_TOKEN }}
 
-    - name: Install pre-commit
-      run: |
-        python -m pip install --upgrade pip
-        pip install pre-commit
-        pre-commit install
-
-    # Job will fail if pre-commit checks fail
     - name: Commit tracked files only
       id: commit
-      shell: bash
-      run: |
-        git checkout -b ${{ env.branchName }}
-        git config --local user.name "GitHub Actions"
-        git config --local user.email ""
-        git add -u source/locale
-        git add -u user_docs
-
-        # Check if there are any changes to commit
-        if git diff --staged --quiet; then
-          echo "No changes to commit"
-          echo "has_changes=false" >> $GITHUB_OUTPUT
-        else
-          git commit -m "Update tracked translations from Crowdin"
-          echo "has_changes=true" >> $GITHUB_OUTPUT
-        fi
+      run: ci/scripts/checkAndCommitTranslations.ps1 -branchName ${{ env.branchName }}
 
     - name: Create pull request
       if: steps.commit.outputs.has_changes == 'true'
-      shell: bash
       run: |
         git push --set-upstream origin ${{ env.branchName }}
         # Create a pull request for the changes
-        gh pr create --base beta --head ${{ env.branchName }} \
-        --title "Update tracked translations from Crowdin" \
+        gh pr create --base beta --head ${{ env.branchName }} `
+        --title "Update tracked translations from Crowdin" `
         --body "This pull request updates translations to languages being tracked from Crowdin."
       env:
         GITHUB_TOKEN: ${{ github.token }}
 
     - name: Merge pull request
       if: steps.commit.outputs.has_changes == 'true'
-      shell: bash
-      # Sets PR to auto-merge when checks have passed
       run: |
-        gh pr merge ${{ env.branchName }} \
-        --squash --delete-branch --auto \
+        # Sets PR to auto-merge when checks have passed
+        gh pr merge ${{ env.branchName }} `
+        --squash --delete-branch --auto `
         --body "Merged translations from Crowdin"
       env:
         GITHUB_TOKEN: ${{ github.token }}
+
+    - name: Notify translators of errors
+      if: steps.commit.outputs.has_failures == 'true'
+      uses: dawidd6/action-send-mail@v4
+      with:
+        server_address: ${{ secrets.EMAIL_SERVER_ADDRESS }}
+        server_port: ${{ secrets.EMAIL_SERVER_PORT || 465 }}
+        username: ${{ secrets.EMAIL_USERNAME }}
+        password: ${{ secrets.EMAIL_PASSWORD }}
+        subject: "[${{ steps.commit.outputs.invalid_pofile_locales }}]: Errors in interface translations"
+        to: nvda-l10n@nvaccess.org
+        from: '"NVDA localisations" <nvda-l10n@nvaccess.org>'
+        convert_markdown: true
+        body: |
+          Errors have been found in the user interface translations for the following locales: ${{ steps.commit.outputs.invalid_pofile_locales }}.
+          Detailed reports are included below.
+          Updated translations for these locales will not be included in NVDA until these errors have been corrected.
+
+          For more information, review the guide on translating NVDA's interface: <https://github.com/nvaccess/nvda/blob/master/projectDocs/translating/crowdin.md#translating-nvdas-interface>.
+
+          ----------
+          ${{ steps.commit.outputs.invalid_pofile_reports }}
+
+        html_body: |
+          Errors have been found in the user interface translations for the following locales: ${{ steps.commit.outputs.invalid_pofile_locales }}.
+          Detailed reports are included below.
+          Updated translations for these locales will not be included in NVDA until these errors have been corrected.
+
+          For more information, [review the guide on translating NVDA's interface](https://github.com/nvaccess/nvda/blob/master/projectDocs/translating/crowdin.md#translating-nvdas-interface).
+
+          ```
+          ----------
+          ${{ steps.commit.outputs.invalid_pofile_reports }}
+          ```

.github/workflows/monitor-localisation-file-changes.yml

@@ -7,11 +7,25 @@ on:
     paths:
       - 'source/locale/en/*.dic'
 
+permissions:
+  actions: write
+
 jobs:
   send_email:
     runs-on: ubuntu-latest
 
     steps:
+    - name: Early exit
+      run: |
+        if [ -z "${{ secrets.EMAIL_USERNAME }}" ]; then
+          echo "EMAIL_USERNAME is not set. Exiting workflow."
+          gh run cancel ${{ github.run_id }}
+          gh run watch ${{ github.run_id }}
+        fi
+      env:
+        GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        GH_REPO: ${{ github.repository }}
+
     - name: Checkout repository
       uses: actions/checkout@v4
       with:
@@ -33,8 +47,8 @@ jobs:
     - name: Send email
       uses: dawidd6/action-send-mail@v4
       with:
-        server_address: email-smtp.us-west-2.amazonaws.com
-        server_port: 465
+        server_address: ${{ secrets.EMAIL_SERVER_ADDRESS }}
+        server_port: ${{ secrets.EMAIL_SERVER_PORT || 465 }}
         username: ${{ secrets.EMAIL_USERNAME }}
         password: ${{ secrets.EMAIL_PASSWORD }}
         subject: "Changes detected in localisation files"