Skip to content

Fixup for Chinese Word Segmentation and Braille Output#19324

Merged
seanbudd merged 7 commits intonvaccess:try-chineseWordSegmentation-stagingfrom
CrazySteve0605:fixupOSPP2025
Mar 2, 2026
Merged

Fixup for Chinese Word Segmentation and Braille Output#19324
seanbudd merged 7 commits intonvaccess:try-chineseWordSegmentation-stagingfrom
CrazySteve0605:fixupOSPP2025

Conversation

@CrazySteve0605
Copy link
Copy Markdown
Contributor

@CrazySteve0605 CrazySteve0605 commented Dec 3, 2025

Fixup for Chinese word segmentation and braille output.

Link to issue number:

Summary of the issue:

Some punctuations have extra separators (spaces) before or after them.

Description of user facing changes:

Braille output will be more accurate.

Description of developer facing changes:

None

Description of development approach:

Testing strategy:

Run the updated code and check if the punctuation marks are handled the way they should be.

Known issues with pull request:

Code Review Checklist:

  • Documentation:
    • Change log entry
    • User Documentation
    • Developer / Technical Documentation
    • Context sensitive help for GUI changes
  • Testing:
    • Unit tests
    • System (end to end) tests
    • Manual testing
  • UX of all users considered:
    • Speech
    • Braille
    • Low Vision
    • Different web browsers
    • Localization in other languages / culture than English
  • API is compatible with existing add-ons.
  • Security precautions taken.

@seanbudd seanbudd added the conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review. label Dec 4, 2025
@seanbudd
Copy link
Copy Markdown
Member

seanbudd commented Feb 3, 2026

@CrazySteve0605 - do you intend to continue to work on this?

@CrazySteve0605
Copy link
Copy Markdown
Contributor Author

Hi @seanbudd ,
Yes but I'm not sure when I can solve the issue. Currently, NVDA doesn't run successfully in launcher way but works well in source way, and I didn't find key information from log.

@seanbudd
Copy link
Copy Markdown
Member

seanbudd commented Feb 3, 2026

Can you explain what you mean by that? Are you downloading the launcher from this PR? Can you share the log after you run the PR? The system tests here show that the launcher runs fine

@cary-rowen
Copy link
Copy Markdown
Contributor

I tested it manually, and from my brief test, the word segmentation works fine. I believe you can continue with the next steps.

@CrazySteve0605 CrazySteve0605 marked this pull request as ready for review February 10, 2026 07:41
@CrazySteve0605 CrazySteve0605 requested a review from a team as a code owner February 10, 2026 07:41
@CrazySteve0605 CrazySteve0605 requested review from SaschaCowley and removed request for a team February 10, 2026 07:41
@CrazySteve0605
Copy link
Copy Markdown
Contributor Author

Now I'd like to make it ready for review.

@cary-rowen
Copy link
Copy Markdown
Contributor

Hi there, it looks like you might need to fill out the PR template and sync your branch with the latest changes from master . Also, please keep an eye on the unit test results, as some checks seem to be failing. Thanks!

@CrazySteve0605 CrazySteve0605 marked this pull request as draft February 11, 2026 02:54
@seanbudd
Copy link
Copy Markdown
Member

@CrazySteve0605 - do you intend to continue to work on this?

@CrazySteve0605
Copy link
Copy Markdown
Contributor Author

Hi @cary-rowen and @seanbudd,

I'd like to mark this PR as ready for review. Thanks for your continued attention to this PR.

@cary-rowen, regarding your feedback:

sync your branch with the latest changes from master.

This will be addressed in a separate PR (#19166).

keep an eye on the unit test results, as some checks seem to be failing.

The errors appear to be intermittent or possibly related to external dependencies. I ran the CI/CD in my fork (https://github.com/CrazySteve0605/nvda/actions/runs/21888959415) without any code modifications, and it passed successfully.

@CrazySteve0605 CrazySteve0605 marked this pull request as ready for review March 1, 2026 01:04
@seanbudd seanbudd merged commit 096e985 into nvaccess:try-chineseWordSegmentation-staging Mar 2, 2026
1 of 2 checks passed
@github-actions github-actions bot added this to the 2026.2 milestone Mar 2, 2026
@CrazySteve0605 CrazySteve0605 deleted the fixupOSPP2025 branch March 5, 2026 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conceptApproved Similar 'triaged' for issues, PR accepted in theory, implementation needs review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants