Fixup for Chinese Word Segmentation and Braille Output#19324
Conversation
e1acfd0 to
cf6ccb7
Compare
|
@CrazySteve0605 - do you intend to continue to work on this? |
|
Hi @seanbudd , |
|
Can you explain what you mean by that? Are you downloading the launcher from this PR? Can you share the log after you run the PR? The system tests here show that the launcher runs fine |
|
I tested it manually, and from my brief test, the word segmentation works fine. I believe you can continue with the next steps. |
|
Now I'd like to make it ready for review. |
|
Hi there, it looks like you might need to fill out the PR template and sync your branch with the latest changes from master . Also, please keep an eye on the unit test results, as some checks seem to be failing. Thanks! |
|
@CrazySteve0605 - do you intend to continue to work on this? |
|
Hi @cary-rowen and @seanbudd, I'd like to mark this PR as ready for review. Thanks for your continued attention to this PR. @cary-rowen, regarding your feedback:
This will be addressed in a separate PR (#19166).
The errors appear to be intermittent or possibly related to external dependencies. I ran the CI/CD in my fork (https://github.com/CrazySteve0605/nvda/actions/runs/21888959415) without any code modifications, and it passed successfully. |
…ressing suggestion from @seanbudd
096e985
into
nvaccess:try-chineseWordSegmentation-staging
Fixup for Chinese word segmentation and braille output.
Link to issue number:
Summary of the issue:
Some punctuations have extra separators (spaces) before or after them.
Description of user facing changes:
Braille output will be more accurate.
Description of developer facing changes:
None
Description of development approach:
Testing strategy:
Run the updated code and check if the punctuation marks are handled the way they should be.
Known issues with pull request:
Code Review Checklist: