Skip to content

fix: resolve heap-use-after-free in NoteListView on exit (#732) #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bomlinux92-byte wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: resolve heap-use-after-free in NoteListView on exit (#732) #772

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 13 additions & 2 deletions src/notelistview.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,13 +193,24 @@ void NoteListView::setEditorWidget(int noteId, QWidget *w)

void NoteListView::unsetEditorWidget(int noteId, QWidget *w)
{
if (m_openedEditor.contains(noteId)) {
m_openedEditor[noteId].removeAll(w);
// Skip if trying to remove nullptr - this is a no-op and can cause
// issues during destruction when the map state may be inconsistent
if (w == nullptr) {
return;
}
auto it = m_openedEditor.find(noteId);
if (it != m_openedEditor.end()) {
it.value().removeAll(w);
}
}

void NoteListView::closeAllEditor()
{
// Check if model is still valid before iterating
if (!model()) {
m_openedEditor.clear();
return;
}
for (const auto &id : m_openedEditor.keys()) {
auto index = static_cast<NoteListModel *>(model())->getNoteIndex(id);
closePersistentEditor(index);
Expand Down