[infra] CI 優化:backend unit test 改用 native Go,移除 artifact roundtrip#438
[infra] CI 優化:backend unit test 改用 native Go,移除 artifact roundtrip#438github-actions[bot] merged 4 commits intodevelopfrom
Conversation
PR Scope Police
Snapshot
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5f2df75eed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
WalkthroughCI 工作流程移除了後端 Docker image artifact 的上傳/下載環節,改為直接在 runner 上用原生 Go 工具執行測試與檢查。同時刪除 Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Erick52106
left a comment
There was a problem hiding this comment.
Summary
先留一般 review comment,不提交 Change Request。
Blockers
.github/workflows/ci.yml:257/:260/:264
backend job 指向 services/api/go.mod 並在 services/api 執行,但 PR head 上 services/api/go.mod 目前是 404;repo 目前存在的是 backend/go.mod。一旦 scope gate 放行 backend CI,actions/setup-go 或後續 working-directory 會直接失敗。建議改回 backend/go.mod / working-directory: backend,並同步修正 .github/workflows/ci.test.mjs 斷言。
.github/workflows/ci.yml:351-376
這輪 checks 顯示 Backend tests、Build backend image、Backend integration tests 都是 SKIPPED,但 Backend CI (gate) 仍通過,因為 gate 接受 skipped。也就是說,PR 目前沒有實際驗證本次修改的 backend CI 路徑,也無法證明 issue #437 的「backend critical path 縮短」完成條件。建議先修 PR body / scope gate 條件讓 heavy CI 跑起來,再確認 backend jobs 真正成功。
Notes
actions/setup-go@v6 本身已發布,使用 ubuntu-latest GitHub-hosted runner 通常可接受;這點不是 blocker。
8b0a9fb to
d5da829
Compare
refs #437 Co-Authored-By: Codex <codex[bot]@openai.com>
d5da829 to
366a37f
Compare
refs #437 Co-Authored-By: Codex <codex[bot]@openai.com>
Erick52106
left a comment
There was a problem hiding this comment.
再審後確認上一輪兩個 blocker 都已解除:
services/api/go.mod在 PR head 已存在,backend/backend-integration改用services/api的路徑可以成立。- 最新 CI 已實際跑過並通過
Build backend image、Backend tests、Backend integration tests、Check backend CI cache wiring、Workflow regression tests。
沒有發現新的 blocker / major。建議 merge。
Summary
backendjob removes artifact download / docker load and runs native Go tests withactions/setup-go@v6.backendnow runsgo test ./...andgo vet ./...fromservices/api.backend-buildkeeps Docker build cache validation but removes image artifact export/upload roundtrip.backendno longer depends onbackend-build;backend-cigate still depends onbackend-build,backend, andbackend-integration.Source of truth:#437
Closes #437
Depends on PR:none
Backend contract already in develop:
本 PR 明確不做
backend-integrationbeyond staying aligned with theservices/apiservice root from [backend] Move backend service into services/api #435.Verification
bash scripts/check-backend-ci-cache.shnode --test .github/workflows/ci.test.mjs— 10/10 passedruby -e "require 'yaml'; YAML.safe_load(File.read('.github/workflows/ci.yml'), permitted_classes: [], aliases: false); YAML.safe_load(File.read('.github/workflows/pr-scope-police.yml'), permitted_classes: [], aliases: false); puts 'yaml ok'"go test ./...fromservices/apigo vet ./...fromservices/apigit diff --check