feat(core): add logging and progress message types to daemon by AgentEnder · Pull Request #35342 · nrwl/nx

AgentEnder · 2026-04-18T16:07:57Z

Current Behavior

During graph creation theres no simple way to know which plugin is taking time if the daemon is enabled. Instead, we instruct users to rerun with --no-daemon to see better logging..... which isnt ideal.

Expected Behavior

The daemon is capable of updating the client on its progress without triggering the current promises resolution / rejection

Related Issue(s)

Fixes #

Introduces two new daemon message types that are not expected to resolve the pending client request promise: - UPDATE_PROGRESS_MESSAGE: updates the client-side spinner while a request is in flight so long-running work (e.g. plugin loading) can surface which step it is currently on. - EMIT_LOG: forwards a log line from the daemon to the requesting client so warnings emitted inside the daemon reach the user's terminal instead of disappearing into the daemon log file. The daemon wraps each handler in an AsyncLocalStorage-scoped context keyed on the requesting socket so code deep in the handler call tree can stream messages back to the right client without threading the socket through every layer. The client-side handleMessage is taught to route the new message types into globalSpinner.updateText and console[level] instead of resolving the pending promise. https://claude.ai/code/session_014sDuF5eLunmQPHsRRWLTMo

Plugin workers gain an emitLog / updateProgress notification channel back to their host process. Notifications are unsolicited (no tx, no response expected) so plugin code can fire them without coupling to the request/response protocol. The isolated-plugin host handles notifications differently depending on whose process it is running in: - When the host is the daemon, the notification is forwarded to the active client socket via the emit-log / update-progress-message streaming messages introduced in the previous commit. - When the host is the direct CLI (no daemon), log notifications are written straight to stdout/stderr. Progress notifications are dropped since the CLI already owns the in-process spinner. https://claude.ai/code/session_014sDuF5eLunmQPHsRRWLTMo

Wires up the first two real uses of the streaming message channel: - createProjectConfigurationsWithPlugins now sends its in-flight spinner text through sendProgressMessageToClient. Under the daemon the local spinner is a no-op, so this makes the client-side spinner reflect which plugin is still running (e.g. "Creating project graph nodes with @nx/jest") rather than the generic "Calculating the project graph on the Nx Daemon" message. - The graph cache-write failure warning in writeCache is routed to emitLogToClient when running on the daemon. Previously the warning landed only in the daemon log and users never saw it. https://claude.ai/code/session_014sDuF5eLunmQPHsRRWLTMo

netlify · 2026-04-18T16:08:03Z

✅ Deploy Preview for nx-docs ready!

Name	Link
🔨 Latest commit	`f64e9e8`
🔍 Latest deploy log	https://app.netlify.com/projects/nx-docs/deploys/69e815d7b19a5c0008c4768d
😎 Deploy Preview	https://deploy-preview-35342--nx-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

netlify · 2026-04-18T16:08:03Z

✅ Deploy Preview for nx-dev ready!

Name	Link
🔨 Latest commit	`f64e9e8`
🔍 Latest deploy log	https://app.netlify.com/projects/nx-dev/deploys/69e815d722bd0c0008364d8e
😎 Deploy Preview	https://deploy-preview-35342--nx-dev.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

nx-cloud · 2026-04-18T16:08:24Z

View your CI Pipeline Execution ↗ for commit f64e9e8

Command	Status	Duration	Result
`nx affected --targets=lint,test,build,e2e,e2e-c...`	✅ Succeeded	54m 4s	View ↗
`nx run-many -t check-imports check-lock-files c...`	✅ Succeeded	3s	View ↗
`nx-cloud record -- pnpm nx-cloud conformance:check`	✅ Succeeded	18s	View ↗
`nx build workspace-plugin`	✅ Succeeded	<1s	View ↗
`nx-cloud record -- nx sync:check`	✅ Succeeded	24s	View ↗
`nx-cloud record -- nx format:check`	✅ Succeeded	15s	View ↗

☁️ Nx Cloud last updated this comment at 2026-04-22 01:24:46 UTC

AgentEnder · 2026-04-18T16:13:53Z

Let's revert this one, its fine to stay in daemon logs

AgentEnder · 2026-04-18T16:14:26Z

+    // When running inside the daemon the local spinner is a no-op
+    // (daemon has no TTY), so forward the message to the connected
+    // client so their spinner reflects which plugin is still running.
+    sendProgressMessageToClient(message);


This should probably have a isOnDaemon guard

Addresses review feedback on #35342: - sendProgressMessageToClient and emitLogToClient now throw when called outside of the Nx daemon process, making misuse loud rather than silent. - createProjectConfigurationsWithPlugins gates the progress forwarding behind isOnDaemon() so the helpers are never reached in the direct CLI case. - Reverts the emit-log use of the cache-write failure warning — that warning is fine staying in the daemon log. https://claude.ai/code/session_014sDuF5eLunmQPHsRRWLTMo

FrozenPandaz · 2026-04-20T21:18:52Z

+        return;
+      }
+      if (isEmitLogMessage(parsedResult)) {
+        // eslint-disable-next-line no-console


I don't think this is disallowed

FrozenPandaz · 2026-04-20T21:21:42Z

+
+function writeStreamingMessage(socket: Socket, payload: unknown) {
+  try {
+    socket.write(JSON.stringify(payload) + MESSAGE_END_SEQ, (err) => {


Use the JSON serialize abstraction with v8 handling.

FrozenPandaz · 2026-04-20T21:30:37Z

+  level: PluginWorkerEmitLogNotification['level'],
+  message: string
+): void {
+  if (!hostSocket) return;


If plugin isolation is turned off this should probably log it?

FrozenPandaz · 2026-04-20T21:32:30Z

+export function getActiveClientSocket(): Socket | undefined {
+  return clientSocketStorage.getStore();
+}


inline this

FrozenPandaz · 2026-04-20T21:44:03Z

+  if (isOnDaemon()) {
+    sendProgressMessageToClient(initialMessage);
+  }


Move this into DelayedSpinner and don't change this at all. This will make it work for createDependencies as well.

FrozenPandaz · 2026-04-20T21:51:50Z

+ *
+ * Must only be invoked from inside the Nx daemon process.
+ */
+export function emitLogToClient(level: EmitLogLevel, message: string): void {


Proxy this function to the daemonLogger

FrozenPandaz · 2026-04-20T21:57:37Z

+    if (notification.type === 'emitLog') {
+      emitLogToClient(notification.level, notification.message);
+    } else if (notification.type === 'updateProgress') {
+      sendProgressMessageToClient(notification.message);


We don't currently have a use case for progress messages from plugin workers... so let's remove it for now.

Addresses a second round of review feedback on #35342: - emitLogToClient is now a method on DaemonLogger (serverLogger.emitToClient) so daemon-to-client log forwarding lives alongside the rest of the daemon logging surface. - Progress forwarding moves into DelayedSpinner itself rather than living at the call site. Any caller that uses DelayedSpinner inside the daemon now automatically streams progress to the client — this picks up createDependencies and createMetadata for free. project-configuration-utils.ts is reverted to its original shape. - writeStreamingMessage uses the shared serialize() helper with v8 handling instead of a bespoke JSON.stringify call. - getActiveClientSocket is used across files, kept as a small named export rather than inlined. - emit-log notifications from plugin workers now fall back to stdout/stderr when no host socket is connected, so they aren't silently dropped when plugin isolation is off. - Drop the unused plugin-worker updateProgress notification path and accompanying types — there's no caller for it yet. - Remove an unnecessary eslint-disable on a console[level] call that isn't actually disallowed. https://claude.ai/code/session_014sDuF5eLunmQPHsRRWLTMo

Replace the AsyncLocalStorage single-socket progress model with a topic-based subscriber registry. Long-running daemon operations register subscribers for a named topic on entry and unregister on exit; broadcast helpers fan out to every currently-subscribed socket. - Introduces ProgressTopics.GraphConstruction as the first (and only) topic today. Add more as other daemon operations grow their own streaming surfaces. - getCachedSerializedProjectGraphPromise now takes the requesting socket and subscribes it to GraphConstruction for the duration of the await. Clients that join a recomputation already in flight now receive the remaining progress messages — previously only the client that initiated the compute got them, and file-watcher-triggered recomputations produced no notifications at all. - DelayedSpinner accepts an optional progressTopic option; when set and running inside the daemon, every setMessage broadcasts to that topic's subscribers. - DaemonLogger#logToClient now takes a topic and falls back to the daemon log when no clients are subscribed. https://claude.ai/code

The topic constant is the contract between progress producers (DelayedSpinner callers) and the daemon subscriber registry, so it belongs next to the spinner rather than inside the daemon's client-socket bookkeeping. Also sidesteps a latent import cycle between delayed-spinner.ts and the daemon server module. https://claude.ai/code

The client does not render hashing progress (handleMessage ignores streaming messages outside of REQUEST_PROJECT_GRAPH), so subscribing the hash path was pure coupling and wasted socket traffic. Revert handleHashTasks to its socket-less signature. https://claude.ai/code

The client previously mutated the process-wide globalSpinner on every incoming progress message, which could overwrite the text of an unrelated command that had started its own spinner. Since the daemon client is a serialized message queue, carry the owning spinner alongside the in-flight request via a new currentSpinner field (set inside the queued function and cleared in a finally). handleMessage now drives that spinner directly, so streamed updates never reach anyone else's UI. https://claude.ai/code

FrozenPandaz · 2026-04-21T21:32:25Z

  private async sendToDaemonViaQueue<T extends DaemonMessage>(
    messageToDaemon: T,
-    force?: 'v8' | 'json'
+    options?: { force?: 'v8' | 'json'; spinner?: DelayedSpinner }


Suggested change

options?: { force?: 'v8' | 'json'; spinner?: DelayedSpinner }

options?: { parser?: 'v8' | 'json'; spinner?: DelayedSpinner }

FrozenPandaz · 2026-04-21T21:37:26Z

    preventRecursionInGraphConstruction();
    let spinner: DelayedSpinner;
    // If the graph takes a while to load, we want to show a spinner.
    spinner = new DelayedSpinner(


Set this.currentSpinner here and add a finally block to null it.

FrozenPandaz · 2026-04-21T21:46:29Z

+  try {
+    socket.write(serialize(payload) + MESSAGE_END_SEQ, (err) => {
+      if (err) {
+        console.log(
+          `Streaming message write error (client likely disconnected): ${err.message}`
+        );
+      }
+    });
+  } catch (e) {
+    console.log(
+      `Failed to send streaming message to client: ${
+        e instanceof Error ? e.message : String(e)
+      }`
+    );
+  }


Look at respondToClient from shutdown-utils and borrow some ideas like logging this into the server logs etc.

FrozenPandaz · 2026-04-21T21:51:55Z

+  message: string
+): void {
+  assertOnDaemon('sendProgressMessageToTopic');
+  const subscribers = topicSubscribers.get(topic);


Use getTopicSubscribers

FrozenPandaz · 2026-04-21T21:57:48Z

+   *
+   * Must only be invoked from inside the Nx daemon process.
+   */
+  logToClient(topic: ProgressTopic, level: EmitLogLevel, message: string) {


This should import a function from the client socket context... shouldn't have the implementation here

FrozenPandaz · 2026-04-21T22:02:30Z

+  const stream =
+    notification.level === 'error' ? process.stderr : process.stdout;
+  stream.write(notification.message + '\n');


Use console so that it is parity with the daemon client.

FrozenPandaz · 2026-04-21T22:07:33Z

+    const stream = level === 'error' ? process.stderr : process.stdout;
+    stream.write(message + '\n');


Use console[level]()

Addresses review feedback on #35342: - writeStreamingMessage now mirrors the logging shape of respondToClient in shutdown-utils (broadcast / done / error lines via serverLogger, with the message type as the description). - Move the broadcast-to-subscribers implementation into client-socket-context as sendLogToTopic; DaemonLogger#logToClient now orchestrates it and falls back to the daemon log only when nobody is subscribed. - sendProgressMessageToTopic and sendLogToTopic go through the exported getTopicSubscribers helper rather than peeking at the internal map directly. - Rename the sendToDaemonViaQueue option from `force` to `parser` for clarity and drop the spinner plumbing from it. The caller (getProjectGraphAndSourceMaps) now sets `this.currentSpinner` directly and clears it in a finally block. - isolated-plugin.ts and worker-streaming.ts fall back to `console[level]()` for log notifications instead of raw process.stdout/stderr writes, keeping parity with how the daemon client renders emit-log messages. https://claude.ai/code/session_014sDuF5eLunmQPHsRRWLTMo

FrozenPandaz · 2026-04-22T00:21:23Z

-  function updateSpinner() {
+  function getSpinnerText() {
    if (!spinner || inProgressPlugins.size === 0) {
      return;


Does this clear the spinner message?

FrozenPandaz · 2026-04-22T00:23:45Z

+  function getSpinnerText() {
    if (!spinner || inProgressPlugins.size === 0) {
-      return;
+      return '';


Is this correct or is the one above correct?

github-actions · 2026-04-28T00:28:45Z

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

claude added 3 commits April 18, 2026 15:45

AgentEnder changed the title ~~feat: add logging and progress message types to daemon~~ feat(core): add logging and progress message types to daemon Apr 18, 2026

AgentEnder commented Apr 18, 2026

View reviewed changes

AgentEnder marked this pull request as ready for review April 20, 2026 19:04

AgentEnder requested a review from a team as a code owner April 20, 2026 19:04

AgentEnder requested a review from JamesHenry April 20, 2026 19:04

FrozenPandaz requested changes Apr 20, 2026

View reviewed changes

claude and others added 5 commits April 20, 2026 22:02

FrozenPandaz requested changes Apr 21, 2026

View reviewed changes

AgentEnder force-pushed the claude/add-progress-messages-7GGDP branch from f3405d9 to 8a1c4ba Compare April 21, 2026 22:58

FrozenPandaz approved these changes Apr 22, 2026

View reviewed changes

fix(core): code review feedback

f64e9e8

AgentEnder force-pushed the claude/add-progress-messages-7GGDP branch from 8a1c4ba to f64e9e8 Compare April 22, 2026 00:27

AgentEnder enabled auto-merge (squash) April 22, 2026 00:35

AgentEnder merged commit 362ff61 into master Apr 22, 2026
23 checks passed

AgentEnder deleted the claude/add-progress-messages-7GGDP branch April 22, 2026 01:25

github-actions Bot locked as resolved and limited conversation to collaborators Apr 28, 2026

	options?: { force?: 'v8' \| 'json'; spinner?: DelayedSpinner }
	options?: { parser?: 'v8' \| 'json'; spinner?: DelayedSpinner }

		const stream = level === 'error' ? process.stderr : process.stdout;
		stream.write(message + '\n');

Conversation

AgentEnder commented Apr 18, 2026

Current Behavior

Expected Behavior

Related Issue(s)

Uh oh!

netlify Bot commented Apr 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for nx-docs ready!

Uh oh!

netlify Bot commented Apr 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for nx-dev ready!

Uh oh!

nx-cloud Bot commented Apr 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

FrozenPandaz Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions Bot commented Apr 28, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify Bot commented Apr 18, 2026 •

edited

Loading

netlify Bot commented Apr 18, 2026 •

edited

Loading

nx-cloud Bot commented Apr 18, 2026 •

edited

Loading

FrozenPandaz Apr 20, 2026 •

edited

Loading