chore(vue): add optional peer dependencies#35263
Closed
AgentEnder wants to merge 1 commit intomasterfrom
Closed
Conversation
…sbuild, and storybook
Contributor
|
View your CI Pipeline Execution ↗ for commit 3e077db ☁️ Nx Cloud last updated this comment at |
❌ Deploy Preview for nx-dev failed. Why did it fail? →
|
❌ Deploy Preview for nx-docs failed. Why did it fail? →
|
FrozenPandaz
added
the
priority: low
Contributor
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current Behavior
The
@nx/vueplugin usesensurePackagefor@nx/cypress,@nx/playwright,@nx/rsbuild, and@nx/storybookbut doesn't declare them as optional peer dependencies.Expected Behavior
These 4 packages are listed as optional peer dependencies via
peerDependencies+peerDependenciesMeta.