Skip to content

chore(repo): update workspace-plugin to hit installed versions of packages#35262

Merged
AgentEnder merged 3 commits intomasterfrom
workspace-plugin-implicit-deps
Apr 22, 2026
Merged

chore(repo): update workspace-plugin to hit installed versions of packages#35262
AgentEnder merged 3 commits intomasterfrom
workspace-plugin-implicit-deps

Conversation

@AgentEnder
Copy link
Copy Markdown
Member

@AgentEnder AgentEnder commented Apr 10, 2026

Current Behavior

workspace-plugin:test has violations

Expected Behavior

image

@AgentEnder AgentEnder requested a review from a team as a code owner April 10, 2026 20:14
@AgentEnder AgentEnder requested a review from FrozenPandaz April 10, 2026 20:14
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 10, 2026

Deploy Preview for nx-dev ready!

Name Link
🔨 Latest commit 3776f68
🔍 Latest deploy log https://app.netlify.com/projects/nx-dev/deploys/69e92c623d073e0008eda9c3
😎 Deploy Preview https://deploy-preview-35262--nx-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 10, 2026

Deploy Preview for nx-docs ready!

Name Link
🔨 Latest commit 3776f68
🔍 Latest deploy log https://app.netlify.com/projects/nx-docs/deploys/69e92c625d90e10008758942
😎 Deploy Preview https://deploy-preview-35262--nx-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nx-cloud
Copy link
Copy Markdown
Contributor

nx-cloud Bot commented Apr 10, 2026

View your CI Pipeline Execution ↗ for commit 3776f68

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 12m 41s View ↗
nx run-many -t check-imports check-lock-files c... ✅ Succeeded 3s View ↗
nx-cloud record -- pnpm nx-cloud conformance:check ✅ Succeeded 16s View ↗
nx build workspace-plugin ✅ Succeeded <1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 20s View ↗
nx-cloud record -- nx format:check ✅ Succeeded 5s View ↗

☁️ Nx Cloud last updated this comment at 2026-04-22 20:31:27 UTC

Copy link
Copy Markdown
Contributor

@nx-cloud nx-cloud Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nx Cloud has identified a flaky task in your failed CI:

🔂 Since the failure was identified as flaky, we triggered a CI rerun by adding an empty commit to this branch.

Nx Cloud View detailed reasoning in Nx Cloud ↗

🔔 Heads up, your workspace has pending recommendations ↗ to auto-apply fixes for similar failures.


🎓 Learn more about Self-Healing CI on nx.dev

@AgentEnder AgentEnder changed the title chore(repo): add implicit deps to workspace-plugin chore(repo): update workspace-plugin to hit installed versions of packages Apr 22, 2026
@AgentEnder AgentEnder force-pushed the workspace-plugin-implicit-deps branch 3 times, most recently from 8a717e0 to c8b06ae Compare April 22, 2026 19:23
@AgentEnder AgentEnder marked this pull request as draft April 22, 2026 20:00
@AgentEnder AgentEnder marked this pull request as ready for review April 22, 2026 20:04
@AgentEnder AgentEnder enabled auto-merge (squash) April 22, 2026 20:13
Revert the implicit dependencies on devkit/eslint/js/nx/plugin and
instead override the workspace-wide jest resolver for this project so
its tests consume the installed versions of @nx/* (as any external
consumer would) rather than being redirected to packages/* source.

Inlines the trivial setCwd helper at its two call sites since the
@nx/devkit/internal-testing-utils subpath isn't part of the published
package.
@AgentEnder AgentEnder force-pushed the workspace-plugin-implicit-deps branch from c8b06ae to 3776f68 Compare April 22, 2026 20:15
@AgentEnder AgentEnder merged commit 77f8e1e into master Apr 22, 2026
23 checks passed
@AgentEnder AgentEnder deleted the workspace-plugin-implicit-deps branch April 22, 2026 20:31
@github-actions
Copy link
Copy Markdown
Contributor

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Apr 28, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants