Skip to content

Fixes calculation of length of command line parameter #432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
davecranwell wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixes calculation of length of command line parameter #432

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions packages/nx-ignore/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,15 @@ const userDefinedPluginsArg = args.find(
(s) => s.startsWith('--plugins=') || s.startsWith('--plugins ')
) as string;
const userDefinedPlugins = userDefinedPluginsArg
? userDefinedPluginsArg.slice(10).split(',')
? userDefinedPluginsArg.slice("--plugins=".length).split(',')
: null;
const userDefinedPackagesArg = args.find(
(s) =>
s.startsWith('--additional-packages=') ||
s.startsWith('--additional-packages ')
) as string;
const userDefinedPackages = userDefinedPackagesArg
? userDefinedPackagesArg.slice(10).split(',')
? userDefinedPackagesArg.slice("--additional-packages=".length).split(',')
: null;
const isVerbose = args.some((s) => s === '--verbose');
// This is always "true" when running on Netlify
Expand All @@ -48,8 +48,8 @@ const isSlimInstall = args.some(
(s) => s === '--slim-install' || s === '--slimInstall'
);
const headSha = 'HEAD';
const userDefinedRoot = customRoot ? customRoot.slice(7) : null;
let baseSha = customBase ? customBase.slice(7) : defaultBase || 'HEAD^';
const userDefinedRoot = customRoot ? customRoot.slice("--root=".length) : null;
let baseSha = customBase ? customBase.slice("--base=".length) : defaultBase || 'HEAD^';

if (!project) {
console.log('≫ No project passed to nx-ignore script');
Expand Down