Skip to content

revert(dashboard): revert "clean up dangling integration links on provider switch" fixes NV-7408#10858

Merged
ChmaraX merged 1 commit intonextfrom
nv-7408-setup-guide-dropdown-accumulates-dangling-integration-links
Apr 25, 2026
Merged

revert(dashboard): revert "clean up dangling integration links on provider switch" fixes NV-7408#10858
ChmaraX merged 1 commit intonextfrom
nv-7408-setup-guide-dropdown-accumulates-dangling-integration-links

Conversation

@ChmaraX
Copy link
Copy Markdown
Contributor

@ChmaraX ChmaraX commented Apr 25, 2026

Summary

Test plan

Made with Cursor

What changed

This PR reverts a previous change that removed integration links when switching providers in the agent setup guide. The reverted change had been attempting to clean up "dangling" integration links by deleting unconnected links during provider selection. However, these links are not actually dangling—they remain visible and manageable in the Integrations tab's "Connected providers" sidebar with proper "Action needed" status indicators. The silent deletion of these links during dropdown exploration was determined to be a worse user experience than preserving them.

Affected areas

dashboard: The agent-setup-guide.tsx component no longer removes integration links during provider selection. The ProviderDropdown onSelect handler now only persists the chosen integration ID to component state and sessionStorage when an integration exists, eliminating calls to removeAgentIntegration and unnecessary query invalidations.

Testing

Manual verification required: verify that agent-setup-guide.tsx matches its state before the reverted PR #10857.

@linear
Copy link
Copy Markdown

linear Bot commented Apr 25, 2026

@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 25, 2026

Deploy Preview for dashboard-v2-novu-staging ready!

Name Link
🔨 Latest commit a9dfef9
🔍 Latest deploy log https://app.netlify.com/projects/dashboard-v2-novu-staging/deploys/69ecc002cab7ea00080481d7
😎 Deploy Preview https://deploy-preview-10858.dashboard-v2.novu-staging.co
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

…er switch in setup guide fixes NV-7408 (#10857)"

This reverts commit 65263ae.
@ChmaraX ChmaraX force-pushed the nv-7408-setup-guide-dropdown-accumulates-dangling-integration-links branch from c31a94b to a9dfef9 Compare April 25, 2026 13:22
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6201b67c-7aca-42f6-82cc-c4484fc84a03

📥 Commits

Reviewing files that changed from the base of the PR and between 65263ae and a9dfef9.

📒 Files selected for processing (1)
  • apps/dashboard/src/components/agents/agent-setup-guide.tsx

📝 Walkthrough

Walkthrough

The provider-selection behavior in the agent setup guide is simplified by removing integration cleanup logic and query invalidation. The ProviderDropdown onSelect handler now only persists the selected integration id to component state and sessionStorage, with associated imports removed.

Changes

Cohort / File(s) Summary
Provider Selection Simplification
apps/dashboard/src/components/agents/agent-setup-guide.tsx
Simplified provider selection handler to remove removeAgentIntegration call and query invalidation logic (getAgentDetailQueryKey). Now only persists integration id to state/sessionStorage when available.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

  • novuhq/novu#10842: Modifies the same component to change provider-selection behavior and integration id persistence logic.
  • novuhq/novu#10857: Also modifies ProviderDropdown selection handling in the same file and impacts integration cleanup/invalidation patterns.
  • novuhq/novu#10752: Affects provider and integration selection logic in the same agent setup guide component.

Suggested labels

@novu/dashboard

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title follows Conventional Commits format with type 'revert', scope 'dashboard', lowercase imperative description, and ends with the Linear ticket reference 'fixes NV-7408'.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@ChmaraX ChmaraX merged commit f74d062 into next Apr 25, 2026
33 of 34 checks passed
@ChmaraX ChmaraX deleted the nv-7408-setup-guide-dropdown-accumulates-dangling-integration-links branch April 25, 2026 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant