Conversation
✅ Deploy Preview for dashboard-v2-novu-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
c31a94b to
a9dfef9
Compare
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe provider-selection behavior in the agent setup guide is simplified by removing integration cleanup logic and query invalidation. The Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
Test plan
agent-setup-guide.tsxmatches the state before fix(dashboard): clean up dangling integration links on provider switch in setup guide fixes NV-7408 #10857Made with Cursor
What changed
This PR reverts a previous change that removed integration links when switching providers in the agent setup guide. The reverted change had been attempting to clean up "dangling" integration links by deleting unconnected links during provider selection. However, these links are not actually dangling—they remain visible and manageable in the Integrations tab's "Connected providers" sidebar with proper "Action needed" status indicators. The silent deletion of these links during dropdown exploration was determined to be a worse user experience than preserving them.
Affected areas
dashboard: The
agent-setup-guide.tsxcomponent no longer removes integration links during provider selection. TheProviderDropdownonSelecthandler now only persists the chosen integration ID to component state andsessionStoragewhen an integration exists, eliminating calls toremoveAgentIntegrationand unnecessary query invalidations.Testing
Manual verification required: verify that
agent-setup-guide.tsxmatches its state before the reverted PR #10857.