-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(api-service,framework): add rich content support and onAction handler for agent cards fixes NV-7363 #10727
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ChmaraX
merged 7 commits into
next
from
nv-7363-agent-framework-rich-content-support-markdown-cards-onaction
Apr 15, 2026
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
da73754
feat(framework): add rich content support with chat SDK re-exports
ChmaraX f7399a5
test(framework): add rich content serialization tests and error guard
ChmaraX 403f3c2
test(framework): verify re-exported card components from chat SDK
ChmaraX c549846
feat(api): accept rich content in agent reply endpoint
ChmaraX 0b51c7e
feat(framework): add onAction event type and SDK handler
ChmaraX 956705e
feat(api-service,framework): add rich content support and onAction ha…
ChmaraX 4f67043
fix(api-service): address PR review — pass files in markdown posts, u…
ChmaraX File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| export enum AgentEventEnum { | ||
| ON_MESSAGE = 'onMessage', | ||
| ON_ACTION = 'onAction', | ||
| ON_RESOLVE = 'onResolve', | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Handle the
resolveaction explicitly.The ack card renders a
resolvebutton, butonActionnever matches it, so clicking Resolve Incident falls into the generic fallback instead of exercising the resolve path.Proposed fix
if (actionId === 'ack') { await ctx.reply( Card({ title: 'Incident Acknowledged', children: [ CardText( `Acknowledged by *${ctx.subscriber?.firstName ?? 'unknown'}* at ${new Date().toLocaleTimeString()}.` ), Actions([Button({ id: 'resolve', label: 'Resolve Incident', style: 'primary' })]), ], }) ); + } else if (actionId === 'resolve') { + ctx.resolve('Incident resolved via action'); + await ctx.reply('Incident resolved.'); } else if (actionId === 'assign') { await ctx.reply(`On-call assignment updated to *${value}*.`); } else if (actionId === 'escalate') { await ctx.reply({ markdown: `**Escalated** — paging the secondary on-call team.\n\n_Triggered by ${ctx.subscriber?.firstName ?? 'unknown'}_`,📝 Committable suggestion
🤖 Prompt for AI Agents