-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(api-service): add emoji reaction support to agent conversations fixes NV-7369 #10726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
ChmaraX
merged 5 commits into
next
from
nv-7369-agent-emoji-reactions-react-to-incoming-messages-and
Apr 15, 2026
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
40b9dd3
feat(api-service): add emoji reaction support to agent conversations β¦
ChmaraX 94a47b0
fix(api-service): add missing mocks for emoji reactions in e2e tests
ChmaraX 967e7ed
feat(api-service): reaction lifecycle β eyes on first message only, rβ¦
ChmaraX cb60fc9
merge: resolve conflicts with origin/next
ChmaraX 899aa88
fix(api-service): allow null in reaction settings DTO validation
ChmaraX File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,9 +1,36 @@ | ||
| import { ApiPropertyOptional } from '@nestjs/swagger'; | ||
| import { IsBoolean, IsOptional } from 'class-validator'; | ||
| import { IsBoolean, IsOptional, IsString, ValidateIf, ValidateNested } from 'class-validator'; | ||
| import { Type } from 'class-transformer'; | ||
|
|
||
| export class AgentReactionSettingsDto { | ||
| @ApiPropertyOptional({ | ||
| description: 'Emoji reaction for incoming messages. Emoji name string to customize, null to disable. Default: "eyes" (π)', | ||
| default: 'eyes', | ||
| }) | ||
| @IsOptional() | ||
| @ValidateIf((_, value) => value !== null) | ||
| @IsString() | ||
| onMessageReceived?: string | null; | ||
|
|
||
| @ApiPropertyOptional({ | ||
| description: 'Emoji reaction when a conversation is resolved. Emoji name string to customize, null to disable. Default: "check" (β )', | ||
| default: 'check', | ||
| }) | ||
| @IsOptional() | ||
| @ValidateIf((_, value) => value !== null) | ||
| @IsString() | ||
| onResolved?: string | null; | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
| } | ||
|
|
||
| export class AgentBehaviorDto { | ||
| @ApiPropertyOptional({ description: 'Show a "Thinking..." indicator while the agent is processing a message' }) | ||
| @IsBoolean() | ||
| @IsOptional() | ||
| thinkingIndicatorEnabled?: boolean; | ||
|
|
||
| @ApiPropertyOptional({ type: AgentReactionSettingsDto, description: 'Automatic emoji reactions on messages' }) | ||
| @ValidateNested() | ||
| @Type(() => AgentReactionSettingsDto) | ||
| @IsOptional() | ||
| reactions?: AgentReactionSettingsDto; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.