Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(api-service): Conversational Agents — full inbound/outbound pipeline with bridge executor fixes NV-7346 #10692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
feat(api-service): Conversational Agents — full inbound/outbound pipeline with bridge executor fixes NV-7346 #10692
Changes from 27 commits
23d3400d1f299966045a24716c258e821f8a68a4dd09f6fce05de19cfa3bb479cd608a4a4069f3a032c46bb11e09ad0af6ef673f3cb1bf659c7c0129adbfe25d1292dc7db3e397b54252b888a04495c3d37bde07ee04877ab4740a97d0f4f94b3978File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SignalDtois missingkeyandvaluefields for metadata signals.The use-case at
handle-agent-reply.usecase.ts:144expects metadata signals to have{ type: 'metadata'; key: string; value: unknown }, but this DTO only validatestype. Incoming metadata signals won't havekey/valuevalidated, allowing malformed payloads to reach the use-case.Consider using a discriminated union or separate DTOs per signal type:
Proposed fix
Then update
AgentReplyPayloadDto.signalsto accept an array ofMetadataSignalDto | TriggerSignalDto.🤖 Prompt for AI Agents
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.