Skip to content

fix(api-service): use NOVU_INTERNAL_SECRET_KEY for agents early access trigger#10688

Merged
scopsy merged 1 commit intonextfrom
cursor/support-internal-secret-key-c20f
Apr 13, 2026
Merged

fix(api-service): use NOVU_INTERNAL_SECRET_KEY for agents early access trigger#10688
scopsy merged 1 commit intonextfrom
cursor/support-internal-secret-key-c20f

Conversation

@scopsy
Copy link
Copy Markdown
Contributor

@scopsy scopsy commented Apr 13, 2026

The POST /support/agents-early-access handler now reads NOVU_INTERNAL_SECRET_KEY instead of NOVU_SECRET_KEY, matching other server-side Novu triggers in the same controller (e.g. mobile-setup) and the internal secret already validated in env.validators.ts.

Breaking change: Deployments must set NOVU_INTERNAL_SECRET_KEY for this workflow to run; relying on NOVU_SECRET_KEY alone will no longer trigger the internal email.

Slack Thread

Open in Web Open in Cursor 

Co-authored-by: Dima Grossman <dima@grossman.io>
@netlify
Copy link
Copy Markdown

netlify bot commented Apr 13, 2026

Deploy Preview for dashboard-v2-novu-staging canceled.

Name Link
🔨 Latest commit 3f78d1c
🔍 Latest deploy log https://app.netlify.com/projects/dashboard-v2-novu-staging/deploys/69dce05c4e28d80008843a83

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 13, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ec04b16d-f419-4f9d-96cc-cbc76304f68f

📥 Commits

Reviewing files that changed from the base of the PR and between 5de6ee7 and 3f78d1c.

📒 Files selected for processing (1)
  • apps/api/src/app/support/support.controller.ts

📝 Walkthrough

Walkthrough

The SupportController.submitAgentsEarlyAccess method updates its environment variable reference from NOVU_SECRET_KEY to NOVU_INTERNAL_SECRET_KEY, with a corresponding warning message update. The control flow and functionality remain unchanged.

Changes

Cohort / File(s) Summary
Environment Variable Update
apps/api/src/app/support/support.controller.ts
Changed Novu secret environment variable from NOVU_SECRET_KEY to NOVU_INTERNAL_SECRET_KEY and updated corresponding warning log message.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions
Copy link
Copy Markdown
Contributor

Hey there and thank you for opening this pull request! 👋

We require pull request titles to follow specific formatting rules and it looks like your proposed title needs to be adjusted.

Your PR title is: fix(api-service): use NOVU_INTERNAL_SECRET_KEY for agents early access trigger

Requirements:

  1. Follow the Conventional Commits specification
  2. As a team member, include Linear ticket ID at the end: fixes TICKET-ID or include it in your branch name

Expected format: feat(scope): Add fancy new feature fixes NOV-123

Details:

PR title must end with 'fixes TICKET-ID' (e.g., 'fixes NOV-123') or include ticket ID in branch name

@scopsy scopsy marked this pull request as ready for review April 13, 2026 12:28
@scopsy scopsy merged commit 20232ac into next Apr 13, 2026
30 of 31 checks passed
@scopsy scopsy deleted the cursor/support-internal-secret-key-c20f branch April 13, 2026 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants