feat(api): rework delayed step behavior#10664
Conversation
👷 Deploy request for dashboard-v2-novu-staging pending review.Visit the deploys page to approve it
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@scopsy I fixed an windows specific error running cp on windows as part of prebuild. |
What changed? Why was the change needed?
This PR reworks digest and delay handling to support manual placeholder-style behavior and bulk control of active workflow runs without introducing a new workflow step.
closes #6915, #5818
Main changes
nonetype of digest and delay steps, requiring no delay conditiontransactionId[]subscriberId[]workflowIdstepNamedigestKeystepTypeWhy this was needed
The goal was to support workflows where digest and delay steps can act as manual placeholders and be resumed or canceled later through the API.
We explicitly chose to add a new Digest/Delay type instead of introducing a new step because this behavior already fits the existing nature of both steps:
So the
nonetype simply leverages that existing behavior rather than creating a brand-new workflow concept.This keeps the workflow model simpler, reuses the current execution pipeline, and avoids unnecessary abstraction.
@coderabbitai summary
Screenshots
Expand for optional sections
Related enterprise PR
Special notes for your reviewer