Fix python kubernetes login for >= v36.0.1#1308
Conversation
90cf403 to
b7369c7
Compare
b7369c7 to
e3b572c
Compare
|
@nolar I'm not sure if this is required anymore post kubernetes-client/python#2604 I'm happy to close if you are happy with only supporting |
This is incorrect. |
|
Indeed, 36.0.2 fixes kubernetes-client/python#2595 Trying out 36.0.2 with some kopf based operator today, doesn't pick up on authentication: |
|
Looks good to me, thanks for fixing it fast. I have also removed an unused import line left from the initial commit. Please sign-off your existing commits as documented in https://docs.kopf.dev/en/stable/contributing/#dco-sign-off — if appropriate, squash them (it is for you to decide). I am going to tighten the rules on external contributions soon in order to avoid all the legal mess that AI contributions create — until resolved somehow some day (now researching). But DCO was in place since a long time ago anyway — a weaker and easier equivalent of CLAs. I will take a look on the mypy & pytest failures with |
Signed-off-by: Mark Farrell <mark.a.farrell@team.telstra.com>
464ef48 to
8f9843f
Compare
@nolar Squashed to a single commit and signed off |
Signed-off-by: Sergey Vasilyev <nolar@nolar.info>
|
|
Released as 1.44.6 Thanks again for the contribution. |
closes #1307