debugger: move ProbeInspectorSession and helpers to separate files#63013
Open
joyeecheung wants to merge 1 commit intonodejs:mainfrom
Open
debugger: move ProbeInspectorSession and helpers to separate files#63013joyeecheung wants to merge 1 commit intonodejs:mainfrom
joyeecheung wants to merge 1 commit intonodejs:mainfrom
Conversation
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
Member
Author
|
cc @nodejs/inspector @hybrist |
Collaborator
hybrist
approved these changes
Apr 28, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #63013 +/- ##
==========================================
- Coverage 89.67% 89.65% -0.03%
==========================================
Files 707 710 +3
Lines 219509 220444 +935
Branches 42093 42274 +181
==========================================
+ Hits 196851 197633 +782
- Misses 14551 14674 +123
- Partials 8107 8137 +30
🚀 New features to boost your workflow:
|
JakobJingleheimer
approved these changes
Apr 28, 2026
legendecas
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the review left by @legendecas in #62713 to move the helpers to a new file. We postponed it due to failing a test triggered by a pre-existing unrelated bug, which has now been skipped in #62808 so this PR finishes that TODO.