Skip to content

debugger: move ProbeInspectorSession and helpers to separate files#63013

Open
joyeecheung wants to merge 1 commit intonodejs:mainfrom
joyeecheung:probe-class
Open

debugger: move ProbeInspectorSession and helpers to separate files#63013
joyeecheung wants to merge 1 commit intonodejs:mainfrom
joyeecheung:probe-class

Conversation

@joyeecheung
Copy link
Copy Markdown
Member

@joyeecheung joyeecheung commented Apr 28, 2026

This addresses the review left by @legendecas in #62713 to move the helpers to a new file. We postponed it due to failing a test triggered by a pre-existing unrelated bug, which has now been skipped in #62808 so this PR finishes that TODO.

Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
@nodejs-github-bot nodejs-github-bot added debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run. labels Apr 28, 2026
@joyeecheung
Copy link
Copy Markdown
Member Author

cc @nodejs/inspector @hybrist

@nodejs-github-bot
Copy link
Copy Markdown
Collaborator

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

❌ Patch coverage is 80.75676% with 178 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.65%. Comparing base (27c7f4d) to head (a1b7af9).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
lib/internal/debugger/inspect_probe.js 77.83% 169 Missing and 5 partials ⚠️
lib/internal/debugger/inspect_helpers.js 96.96% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #63013      +/-   ##
==========================================
- Coverage   89.67%   89.65%   -0.03%     
==========================================
  Files         707      710       +3     
  Lines      219509   220444     +935     
  Branches    42093    42274     +181     
==========================================
+ Hits       196851   197633     +782     
- Misses      14551    14674     +123     
- Partials     8107     8137      +30     
Files with missing lines Coverage Δ
lib/internal/debugger/inspect.js 92.66% <100.00%> (+6.67%) ⬆️
lib/internal/debugger/inspect_helpers.js 96.96% <96.96%> (ø)
lib/internal/debugger/inspect_probe.js 77.83% <77.83%> (ø)

... and 54 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@joyeecheung joyeecheung added request-ci Add this label to start a Jenkins CI on a PR. review wanted PRs that need reviews. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Apr 28, 2026
@legendecas legendecas added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 28, 2026
Copy link
Copy Markdown
Contributor

@Aditi-1400 Aditi-1400 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. debugger Issues and PRs related to the debugger subsystem. needs-ci PRs that need a full CI run. review wanted PRs that need reviews.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants