util: create hex style cache and fast path#62999
Open
araujogui wants to merge 2 commits intonodejs:mainfrom
Open
util: create hex style cache and fast path#62999araujogui wants to merge 2 commits intonodejs:mainfrom
araujogui wants to merge 2 commits intonodejs:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR improves util.styleText() performance for hex colors by introducing a cached hex-style lookup and a fast path for the common case where validateStream: false.
Changes:
- Add a module-level
hexStyleCacheand helper (getHexStyle) to memoize computed ANSI sequences for#RGB/#RRGGBB. - Reuse a shared close sequence constant for 24-bit foreground colors (
\u001b[39m) and integrate hex handling into thevalidateStream: falsefast path. - Refactor hex handling in the main formatting loop to use cached sequences instead of re-parsing on every call.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+121
to
122
| const hexStyleCache = { __proto__: null }; | ||
|
|
Member
There was a problem hiding this comment.
isn't the maximum possible permutations here 16,781,312 - is the memory size of 17 million key/value pairs a massive concern?
Member
Author
There was a problem hiding this comment.
Great point, altought a LRU doesn't seem a bad idea
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #62999 +/- ##
==========================================
- Coverage 89.67% 89.57% -0.11%
==========================================
Files 707 708 +1
Lines 219509 220246 +737
Branches 42093 42188 +95
==========================================
+ Hits 196851 197286 +435
- Misses 14551 14828 +277
- Partials 8107 8132 +25
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve
styleTextperformance by caching and fast-pathBenchmark