Skip to content

lib: use js-only implementation of isDataView() #62780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nodejs-github-bot merged 2 commits into from
Apr 18, 2026
Merged

lib: use js-only implementation of isDataView() #62780

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df1ceaa
lib: use js-only implementation of `isDataView()`
Renegade334 Apr 16, 2026
966fbfc
fixup! lib: use js-only implementation of `isDataView()`
Renegade334 Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions benchmark/util/type-check.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,11 @@ const args = {
'false-primitive': true,
'false-object': int32Array,
},
DataView: {
'true': dataView,
'false-primitive': true,
'false-object': uint8Array,
},
};

const bench = common.createBenchmark(main, {
Expand Down
5 changes: 5 additions & 0 deletions lib/internal/util/types.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@ const {
TypedArrayPrototypeGetSymbolToStringTag,
} = primordials;

function isDataView(value) {
return ArrayBufferIsView(value) && TypedArrayPrototypeGetSymbolToStringTag(value) === undefined;
}

function isTypedArray(value) {
return TypedArrayPrototypeGetSymbolToStringTag(value) !== undefined;
}
Expand Down Expand Up @@ -61,6 +65,7 @@ function isBigUint64Array(value) {
module.exports = {
...internalBinding('types'),
isArrayBufferView: ArrayBufferIsView,
isDataView,
isTypedArray,
isUint8Array,
isUint8ClampedArray,
Expand Down
1 change: 0 additions & 1 deletion src/node_types.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,6 @@ namespace {
V(AsyncFunction) \
V(BigIntObject) \
V(BooleanObject) \
V(DataView) \
V(Date) \
V(External) \
V(GeneratorFunction) \
Expand Down
Loading