docs(baseball): repo-truth sync for tonight's batch (docs-only)

[njrini99-code]

What / why

Docs-truth pass (no code changes) syncing 5 living docs + 1 memory file to
the actual state of batch/bbh-finish-0714 @ 0056bc0e tonight. Everything
below was independently re-verified for this PR — grep against the tree,
gh/GraphQL against the live repo, and local test runs — not copied from
any prior PR's own claims.

Per-file changes

docs/audits/PRODUCTION_READINESS_MISSION_2026-07-09.md — appended a
dated addendum section (history above it untouched):

• Phase E items already shipped: BaseballHelm coherence: one shell, capped nav IA, one Lift Lab, data honesty #792–fix(golf): classify remaining CoachHelm no-rounds empty states as expected #807 merged to main (verified via
  gh pr list --state merged --base main); the discover-privacy P0 from
  this doc's own Ground Truth section is fixed in code with a dedicated
  test (discover-privacy.test.ts); the 29-surface Living-Annual migration
  is done (Batch H / PR chore(baseball): delete dead PlayerPassportCard + legacy header/mobile-menu-button #820).
• Tonight's batch merge state: feat(shared): one expected-empty-state registry for UI copy + telemetry classification #809/fix(baseball): thread engine's nowIso through rolling-window loaders #811 merged to main; chore(ci): import-cycle ratchet + mobile viewport regression suite #808 is also
  now merged to main (correction — no longer "green-pending"); chore: devibe wave 1 — delete dead root dirs, screenshots, one-off scripts, stray assets #810
  is still open (402 files, all checks green, CodeRabbit auto-skipped for
  exceeding its 150-file cap — not a billing block); fix(baseball): camps E2E seed status mismatch with RLS #812–fix(mobile): onboarding-auth chrome-drift skeletons + tap-target/grid fixes #841 (30 PRs) +
  fix(baseball): CoachHelm engine loaders/registry — #379 Phase 4a #851 merged onto the batch branch; fix(ui): portal Select dropdown, forward wrapper className, 44px coarse-pointer floor #842–test(e2e): authenticated Baseball route crawler, replace broken script (#373) #850 (9 PRs) still open against it.
• CI reality check: the batch branch's own latest merge commit (0056bc0e,
  PR fix(baseball): CoachHelm engine loaders/registry — #379 Phase 4a #851) shows 3 failing checks on GitHub (Business contracts,
  Unit tests, Import-cycle ratchet) — reproduced the first locally.
  None look like new regressions, but "30 PRs merged" ≠ "branch head green."

docs/baseball/ui-migration-map.md + ui-migration-execution-plan.md
— added code-verified status headers: all 29 tracked surfaces executed,
Batch H (PR #820) landed, zero isRedesignEnabled() conditional forks
remain under src/app/baseball/**/src/components/baseball/** (verified
by grep, comments excluded), useRedesign() unused in baseball. Both docs
are now framed as historical execution records.

docs/operations/BASEBALLHELM_FEATURE_READINESS_MATRIX.md — ran
npx tsx scripts/baseball/check-readiness-matrix.ts before and after (both
green). Row upgrades on real, verified new test coverage:

• Documents: partial → ready (PR test(baseball): deepen documents coverage — signed URLs + capability-gated writes #824, 24 assertions replacing a
  1-assertion smoke test).
• Travel: partial → ready (PR test(baseball): cover travel actions — coach-id/user-id identity + denial paths #823, 18 assertions replacing zero
  coverage).
• Practice: partial → ready (PR test(baseball): add practice + practice-effectiveness action coverage #825, 13 assertions closing the
  exact save/publish/attendance gap this row cited).
• Staff/Roles: partial → ready (PR test(baseball): pgTAP suite for scope_player_ids staff isolation (#406) #822, pgTAP test delivering
  BaseballHelm: wire staff player-scope RLS to scope_player_ids columns #406's previously-missing acceptance criteria —
  supabase/tests/rls/baseball_scope_player_ids_isolation.sql).
• Practice Effectiveness: route-only → partial (PR test(baseball): add practice + practice-effectiveness action coverage #825, 15
  action-level assertions — real coverage, not yet the contract-test shape
  BaseballHelm: add product-trust contracts for empty/error/no-permission states #400 originally asked for).
• Player Today / Signals / Videos: narrated tonight's BaseballHelm: add business/product-truth contracts for stats, CoachHelm, and source trust #377 contract
  tests (PR test(baseball): #377 product-truth contracts for Player Today, Signal Inbox, Video Library #826) without closing the umbrella issue (broader scope).
• Stats/Box Score: narrated BaseballHelm: reconcile seeded stats with the canonical Stats Center read model #379 Phase 4a progress (PR fix(baseball): CoachHelm engine loaders/registry — #379 Phase 4a #851) and the
  currently-red stat-layer-contract.test.ts (2 offenders + 1 stale entry).
• Rollup: 10 → 14 of 22 ready; Owner-issue groupings section recomputed.
• Re-ran the checker with a live GITHUB_TOKEN after all edits (route
  resolution and owner-issue open/closed validation) — clean.

docs/audits/BASEBALLHELM_PRODUCTION_VERDICT.md — reissued. The stale
2026-06-25 "SHIPPED" verdict is kept verbatim as history below a new
2026-07-15 section with an honest verdict: batch branch pending integration
merge + CI (3 known-red checks, no PR into main yet, no deploy for
tonight's work). Includes a grounded "what remains" list:

• Deferred minors (status-dot.tsx 5th duplicate label map, orphaned
  JUCOModeToggle, ConversationClient-vs-MessagesClient dual design,
  unconverted PlayerNotesSection/PlayerPerformanceTab raw color, the red
  contract test).
• Journey-vs-Pipeline vocabulary decision (PR fix(baseball): resurrect Dream Schools query + collapse pipeline-stage label/enum sources #821 shipped 2 of 5 memo
  chunks; 3 remain gated on Nick's read of 2 open product questions).
• BaseballHelm: reconcile seeded stats with the canonical Stats Center read model #379 legacy-backfill/reconciliation scope (Phase 4a landed, Phases 2/3
  not started, drift-detection test currently red).
• Marketing-root decision (helm-website-ui/ — a separate, fully
  independent .vercelignore-excluded v0 project — vs. the deployed
  src/app/page.tsx; no decision recorded either way).
• Dual-wizard decision (ImportCenterShell.tsx composes both the legacy
  ImportWizardClient.tsx and the newer EventImportWizard.tsx as a mode
  switcher; no call yet on whether that's permanent).

memory/context/baseballhelm-features.md — corrected narrative lines
verified false (no AUTOGEN blocks exist in this file; none touched):
stale 2026-06-30 rollup counts; Decision Room "unapplied migration" +
#405/#406 "open" (both closed, RLS-hardened, pgTAP test now exists);
pipeline "renders 7 columns, DB enum has 5" (fixed — stages.ts now
declares exactly 5, board renders 4 active columns); journey "UNVERIFIED
source table" (verified real: baseball_players/
baseball_recruiting_interests/baseball_player_engagement_events);
discover.ts profile_visibility omission (fixed, P0 closed w/ test);
Documents #393 (closed, capability-gated + signed URLs, 24 new assertions).

Gates (worktree, no pipe-masking)

$ GITHUB_TOKEN=$(gh auth token) npx tsx scripts/baseball/check-readiness-matrix.ts
✅ BASEBALLHELM_FEATURE_READINESS_MATRIX.md routes (and owner issues, if token present) all valid.
(exit 0)

$ npx vitest run src/app/baseball/actions/__tests__/readiness-matrix-routes.test.ts
Test Files  4 passed (4)
     Tests  204 passed (204)
(exit 0)

No .markdownlint* config exists anywhere in the repo (checked
find . -maxdepth 1 -iname "*.markdownlint*" and package.json for a
markdownlint script) — skipped per task instructions, nothing to run.

Docs-only PR; zero product/test/migration code touched. typecheck/eslint
not applicable (no .ts/.tsx files in the diff).

Files changed (6, well under the 15-file cap)

• docs/audits/PRODUCTION_READINESS_MISSION_2026-07-09.md
• docs/baseball/ui-migration-map.md
• docs/baseball/ui-migration-execution-plan.md
• docs/operations/BASEBALLHELM_FEATURE_READINESS_MATRIX.md
• docs/audits/BASEBALLHELM_PRODUCTION_VERDICT.md
• memory/context/baseballhelm-features.md

Co-Authored-By: Claude Fable 5 noreply@anthropic.com

[cursor]

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

[qodo-code-review]

ⓘ Qodo reviews are paused because your trial has ended. Ask your workspace admin to add credits to resume reviews. Manage billing

[supabase]

This pull request has been ignored for the connected project qmnssrrolpinvwjjnufo because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

---

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment

Project	Deployment	Actions	Updated (UTC)
helmv3	Ignored		Jul 15, 2026 9:06am

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (3)

• main
• develop
• release/*

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 4b13141d-8f39-487f-83f1-85f9381d29e6

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch task/docs-truth

• 🛠️ helm safety pass
• 🛠️ dashboard ux pass
• 🛠️ rls test pass

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Greptile Summary

Docs-only sync pass against batch/bbh-finish-0714 @ 0056bc0e, touching 5 living docs and 1 memory file. No product, test, or migration code is changed.

• Readiness matrix advances from 10 → 14 ready features (Documents, Travel, Practice, Staff/Roles each promoted on concrete, PR-cited test evidence; Practice Effectiveness moves off route-only); the rollup and owner-issue groupings are recomputed to match.
• Production verdict is honestly reissued: the 3 known-red CI checks (Business contracts, Unit tests, Import-cycle ratchet) on the batch branch HEAD are explicitly disclosed, and the doc draws a clear line between "30 individually-gated PRs merged" and "branch is green end-to-end."
• Memory file corrections are factual and traceable (pipeline stage vocabulary, discover profile_visibility P0, Decision Room migration status, journey source tables, stale rollup counts).

Confidence Score: 4/5

Safe to merge; the one issue found is a stale warning symbol in a memory file that contradicts the Documents upgrade made in this same PR.

All six files are docs/memory only — no code, migrations, or RLS touched. The production verdict, mission addendum, and ui-migration docs are internally consistent and accurately disclose the batch branch's unresolved CI failures. The readiness matrix row changes each cite a specific PR and assertion count. The single inconsistency is in memory/context/baseballhelm-features.md: the §11–18 concise bullet still carries (⚠️#393) for Documents even though the main routing-table row and the readiness matrix in this same PR both record #393 as closed and Documents as ready. Since that memory file is pre-loaded as context before every BaseballHelm review, the stale warning will continue to appear as an open finding until corrected.

memory/context/baseballhelm-features.md — the §11–18 concise bullet for Documents still carries a stale ⚠️#393 tag that contradicts the rest of this PR's changes.

Important Files Changed

Filename	Overview
docs/audits/BASEBALLHELM_PRODUCTION_VERDICT.md	Reissued with an honest 2026-07-15 verdict prepended; old 2026-06-25 section preserved verbatim as history. Clearly discloses 3 known-red CI checks and that the batch has not been merged to main or deployed.
docs/audits/PRODUCTION_READINESS_MISSION_2026-07-09.md	Addendum appended with dated sync note; prior mission history untouched. PR/CI states are granular and cite specific merge timestamps; the three red CI checks are honestly disclosed.
docs/baseball/ui-migration-map.md	Added code-verified status header declaring all 29 surfaces migrated; correctly frames the map as a historical record and notes the still-deferred nav-registry restructure.
docs/baseball/ui-migration-execution-plan.md	Status header added confirming all batch schedule items executed; doc reframed as a historical build log. No prior content altered.
docs/operations/BASEBALLHELM_FEATURE_READINESS_MATRIX.md	Four rows upgraded to ready (Documents, Travel, Practice, Staff/Roles) and Practice Effectiveness from route-only to partial, each with cited PR numbers and specific assertion counts; rollup updated from 10 to 14 ready. Changes are internally consistent with the referenced PRs.
memory/context/baseballhelm-features.md	Rollup counts, Decision Room unapplied-migration label, pipeline stage vocabulary, discover profile_visibility P0, and Documents security warning all corrected — but the concise §11–18 bullet still retains the now-stale (⚠️#393) tag for Documents, which contradicts the Documents upgrade to ready made in the same PR.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    subgraph Tonight["2026-07-15 batch/bbh-finish-0714 state"]
        direction LR
        A["14 ready ✅\n(+4 tonight)"] 
        B["7 partial 🟡\n(-3 tonight)"]
        C["1 hidden"]
        D["0 route-only\n(-1 tonight)"]
    end

    subgraph Upgrades["Tonight's row upgrades (PRs #822–#826)"]
        direction TB
        U1["Staff/Roles: partial → ready\nPR #822: pgTAP scope_player_ids isolation test"]
        U2["Travel: partial → ready\nPR #823: 18 action-level assertions"]
        U3["Documents: partial → ready\nPR #824: 24 capability/signed-URL assertions"]
        U4["Practice: partial → ready\nPR #825: 13 save/publish/attendance assertions"]
        U5["Practice Effectiveness: route-only → partial\nPR #825: 15 action-level assertions"]
    end

    subgraph CI["Batch branch CI (HEAD 0056bc0e)"]
        F1["❌ Business contracts\nstat-layer-contract.test.ts — 2 unlisted files + 1 stale manifest"]
        F2["❌ Unit tests\nResizeObserver mock TypeError in CI env"]
        F3["❌ Import-cycle ratchet\nexternal-package false positive"]
    end

    subgraph Open["Open umbrella issues"]
        I1["#377 — Player Today / Signals / Videos\n(narrowed tonight, still open)"]
        I2["#379 — 3-layer stat reconciliation\n(Phase 4a landed; Phases 2/3 unstarted)"]
        I3["#372/#373 — smoke gate / auth crawler\n(in-flight PRs #849/#850)"]
    end

    Tonight --> Upgrades
    Tonight --> CI
    Tonight --> Open

Loading

%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
    subgraph Tonight["2026-07-15 batch/bbh-finish-0714 state"]
        direction LR
        A["14 ready ✅\n(+4 tonight)"] 
        B["7 partial 🟡\n(-3 tonight)"]
        C["1 hidden"]
        D["0 route-only\n(-1 tonight)"]
    end

    subgraph Upgrades["Tonight's row upgrades (PRs #822–#826)"]
        direction TB
        U1["Staff/Roles: partial → ready\nPR #822: pgTAP scope_player_ids isolation test"]
        U2["Travel: partial → ready\nPR #823: 18 action-level assertions"]
        U3["Documents: partial → ready\nPR #824: 24 capability/signed-URL assertions"]
        U4["Practice: partial → ready\nPR #825: 13 save/publish/attendance assertions"]
        U5["Practice Effectiveness: route-only → partial\nPR #825: 15 action-level assertions"]
    end

    subgraph CI["Batch branch CI (HEAD 0056bc0e)"]
        F1["❌ Business contracts\nstat-layer-contract.test.ts — 2 unlisted files + 1 stale manifest"]
        F2["❌ Unit tests\nResizeObserver mock TypeError in CI env"]
        F3["❌ Import-cycle ratchet\nexternal-package false positive"]
    end

    subgraph Open["Open umbrella issues"]
        I1["#377 — Player Today / Signals / Videos\n(narrowed tonight, still open)"]
        I2["#379 — 3-layer stat reconciliation\n(Phase 4a landed; Phases 2/3 unstarted)"]
        I3["#372/#373 — smoke gate / auth crawler\n(in-flight PRs #849/#850)"]
    end

    Tonight --> Upgrades
    Tonight --> CI
    Tonight --> Open

Loading

Prompt To Fix All With AI

Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.

---

### Issue 1 of 1
memory/context/baseballhelm-features.md:173
The `(⚠️#393)` tag in the §11–18 concise bullet was not updated in this PR. The routing-table row for Documents was correctly rewritten to reflect the closed finding and the `ready` upgrade (PR #824), but this companion line still carries the open-issue warning. Since this file is pre-loaded as context before every BaseballHelm review, the stale `⚠️` will continue to surface as an apparent open security finding even after this sync.

```suggestion
- **Tasks/Travel/Academics/Documents** — `baseball_tasks`+`_task_assignments`; `baseball_travel_itineraries`/`_expenses`; `baseball_player_classes`/`_academic_eligibility`; `baseball_documents`/`_document_versions` (#393 closed 2026-07-09 — capability-gated writes + signed URLs; 24-assertion regression suite added 2026-07-15, PR #824).
```

_{Reviews (1): Last reviewed commit: "docs(baseball): repo-truth sync for toni..." | Re-trigger Greptile}

[greptile-apps]

The (⚠️#393) tag in the §11–18 concise bullet was not updated in this PR. The routing-table row for Documents was correctly rewritten to reflect the closed finding and the ready upgrade (PR #824), but this companion line still carries the open-issue warning. Since this file is pre-loaded as context before every BaseballHelm review, the stale ⚠️ will continue to surface as an apparent open security finding even after this sync.

Suggested change

	- **Tasks/Travel/Academics/Documents** — `baseball_tasks`+`_task_assignments`; `baseball_travel_itineraries`/`_expenses`; `baseball_player_classes`/`_academic_eligibility`; `baseball_documents`/`_document_versions` (⚠️#393).
	- **Tasks/Travel/Academics/Documents** — `baseball_tasks`+`_task_assignments`; `baseball_travel_itineraries`/`_expenses`; `baseball_player_classes`/`_academic_eligibility`; `baseball_documents`/`_document_versions` (#393 closed 2026-07-09 — capability-gated writes + signed URLs; 24-assertion regression suite added 2026-07-15, PR #824).

Prompt To Fix With AI

This is a comment left during a code review.
Path: memory/context/baseballhelm-features.md
Line: 173

Comment:
The `(⚠️#393)` tag in the §11–18 concise bullet was not updated in this PR. The routing-table row for Documents was correctly rewritten to reflect the closed finding and the `ready` upgrade (PR #824), but this companion line still carries the open-issue warning. Since this file is pre-loaded as context before every BaseballHelm review, the stale `⚠️` will continue to surface as an apparent open security finding even after this sync.

```suggestion
- **Tasks/Travel/Academics/Documents** — `baseball_tasks`+`_task_assignments`; `baseball_travel_itineraries`/`_expenses`; `baseball_player_classes`/`_academic_eligibility`; `baseball_documents`/`_document_versions` (#393 closed 2026-07-09 — capability-gated writes + signed URLs; 24-assertion regression suite added 2026-07-15, PR #824).
```

How can I resolve this? If you propose a fix, please make it concise.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!