Skip to content

Support multi reference predigest mode#88

Open
maxammann wants to merge 3 commits intonjaremko:masterfrom
maxammann:zoo-cleanup
Open

Support multi reference predigest mode#88
maxammann wants to merge 3 commits intonjaremko:masterfrom
maxammann:zoo-cleanup

Conversation

@maxammann
Copy link
Copy Markdown

@maxammann maxammann commented Apr 1, 2026

I just updated this PR to include a way to have a multi signature pre-digest mode. I think this should be fine. Any pre digest data we found is valid and signed.

Also:

  • minor cleanup
  • adds comments
  • pass through reduce mode in b64 mode

@maxammann maxammann changed the title minor cleanup for the new reduce feature Support multi reference predigest mode Apr 2, 2026
@maxammann
Copy link
Copy Markdown
Author

@njaremko I updated this PR to include a rather major change. Lemme know what you think.

@maxammann
Copy link
Copy Markdown
Author

@njaremko I think I found another issue here. The test in db7039e fails in a certain mode. It returns a response instead of an assertion in the case there is only a single assertion.

@maxammann
Copy link
Copy Markdown
Author

Another thing i noticed is that assertion.signed_info.signature_method.algorithm is no longer populated, where assertion is returned by parse_xml_response_with_mode.

@maxammann
Copy link
Copy Markdown
Author

I think we should:

  • remove ValidateAndMark as we can never trust the ancestors. with that mode now we are producing invalid Response ancestors.
  • add a way to restrict libxml's selection or allowed signature algorithms: add feature to allow only certain algorithms #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant