input: support explicit modes (timeout, sticky) for drag-lock#3943
Open
zzzsyyy wants to merge 1 commit into
Open
input: support explicit modes (timeout, sticky) for drag-lock#3943zzzsyyy wants to merge 1 commit into
zzzsyyy wants to merge 1 commit into
Conversation
Previously, `drag-lock` was a boolean flag that enabled the timeout-based drag lock in libinput. However, libinput also supports a "sticky" mode. This commit changes the `drag-lock` config to accept an optional string argument: - `drag-lock "timeout"` - `drag-lock "sticky"` To maintain backward compatibility, specifying `drag-lock` without an argument automatically defaults to the `"timeout"` mode, perfectly preserving the previous behavior for existing configurations.
YaLTeR
reviewed
Apr 30, 2026
| git-version = "0.3.9" | ||
| glam = "0.32.1" | ||
| input = { version = "0.10.0", features = ["libinput_1_21"] } | ||
| input = { version = "0.10.0", features = ["libinput_1_27"] } |
Member
There was a problem hiding this comment.
Do we want to bump the requirement? How's distro support?
Contributor
Author
There was a problem hiding this comment.
the sticky draglock mode was only added in libinput 1.27, and most current stable distros released already ship libinput 1.27 or newer, maybe we need a runtime checker?
Member
There was a problem hiding this comment.
Which distros in particular and which not?
Contributor
Author
There was a problem hiding this comment.
Fedora 43/44, Ubuntu 26.04 LTS, Debian 13 Stable/Testing are, while Ubuntu 24.04 LTS, Debian 12 not
ref: repology
Sempyos
added
area:input
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
drag-lockwas a bool flag that enabled the timeout-based drag lock in libinput. However, libinput also supports a "sticky" mode.This commit changes the
drag-lockconfig to accept an optional string argument:drag-lock "timeout"drag-lock "sticky"upstream recommends "sticky" as the preferred
default mode for drag lock (see: https://lists.freedesktop.org/archives/wayland-devel/2024-November/043860.html).
but keeping "timeout" as the implicit default here can avoid breaking
users' existing muscle memory. should we change it to sticky?