Skip to content

input-method-v1: track/render popups#3543

Draft
WantenMN wants to merge 4 commits intoniri-wm:mainfrom
WantenMN:feat/input-method-v1
Draft

input-method-v1: track/render popups#3543
WantenMN wants to merge 4 commits intoniri-wm:mainfrom
WantenMN:feat/input-method-v1

Conversation

@WantenMN
Copy link
Copy Markdown

@WantenMN WantenMN commented Mar 2, 2026

Summary

This PR adds end-to-end handling for input-method-v1 popups (IME candidate/panel surfaces).

What changed

  • Added InputMethodV1ManagerState initialization and storage in compositor state.
  • Implemented InputMethodV1Handler in State:
    • track popup lifecycle (new_popup, popup_repositioned, dismiss_popup),
    • update popup scale/transform from the target output,
    • compute parent geometry through window/layout context.
  • Added rendering of tracked input-method-v1 popup surfaces in the output render pass.
  • Added commit-time redraw handling for input-method-v1 popup commits.

Why

With the current Smithay stack, niri needs explicit input-method-v1 popup management to correctly place and render IME candidate surfaces and to ensure redraws happen when those surfaces commit.

Merge dependency

This PR depends on Smithay changes and should only be merged after:

@WantenMN WantenMN marked this pull request as draft March 2, 2026 10:33
@WantenMN WantenMN force-pushed the feat/input-method-v1 branch from 9c40698 to 60f06b7 Compare March 2, 2026 13:30
@Atan-D-RP4
Copy link
Copy Markdown
Contributor

Does this resolve #3274?

@Sempyos
Copy link
Copy Markdown
Member

Sempyos commented Mar 3, 2026

I would note.
Smithay/smithay#1937

@Sempyos Sempyos added area:input Keyboard, mouse, touchpad, tablet, gestures, pointer area:wayland Wayland protocols, problems with Wayland handling waiting for upstream Waiting for an upstream project labels Mar 11, 2026
@WantenMN WantenMN changed the title input-method-v1: track/render popups and adapt virtual keyboard integration for new Smithay API input-method-v1: track/render popups Mar 16, 2026
@WantenMN WantenMN force-pushed the feat/input-method-v1 branch from 6e0e71d to eb64682 Compare March 16, 2026 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:input Keyboard, mouse, touchpad, tablet, gestures, pointer area:wayland Wayland protocols, problems with Wayland handling waiting for upstream Waiting for an upstream project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants