Repository navigation
Pin aimnet 0.2.6 and drop the AIMNet2 L-BFGS warning - #54
Merged
Merged
Conversation
aimnet 0.2.6 sizes its batched Coulomb neighbor list by the largest molecule (isayevlab/aimnetcentral#150), so AIMNet2 batches no longer fill the GPU and L-BFGS fits again: mixed and 29k-structure L-BFGS jobs pass for aimnet2 and aimnet2-nse. The BFGS warning stays; its Hessian is a torch-sim limit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins
aimnet[ase,torchsim]==0.2.6, which includes our upstream fix isayevlab/aimnetcentral#150: the batched gas-phase Coulomb neighbor list is now sized by the largest molecule instead of the batch's total atoms. The lock only movesaimnet(0.2.5 → 0.2.6); its dependency ranges are unchanged.With that, AIMNet2 batches no longer fill the GPU, so the temporary AIMNet2 L-BFGS warning and its docs, skill and AGENTS.md lines are removed. The general BFGS warning stays (its dense Hessian is a torch-sim limit for every backend). The
n_atomsmemory-metric rationale is reworded, since memory no longer grows with the square of the batch.Testing