Repository navigation
Single-structure UMA runs use fairchem's default inference settings - #52
Merged
Merged
Conversation
optimize/smiles (one structure) now load the Fairchem calculator with fairchem's default settings, which are faster for one long optimization. Sequential runs over many structures keep "batch", since the default settings drop their compiled model at every new composition. ORB and SevenNet share one cached calculator for both cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Single-structure UMA runs (
optimize,smiles, oroptimize_single_structurewithout a calculator) now load the Fairchem calculator with fairchem's default inference settings. Sequential runs over many structures keep"batch".Why
Benchmark on catalyst (Quadro RTX 6000), d4rev, single ASE optimizations:
"batch"Energies agree within 0.1 meV. The default settings are faster while the composition stays the same, but they drop their compiled model at every new composition. That is why sequential runs keep
"batch".Changes
load_calculator(config, single_structure=False):single_structure=Trueselects fairchem's default settings for Fairchem and is ignored by ORB and SevenNet.optimize_single_structurerequests the single-structure calculator when it loads one itself._optimize_sequentialkeeps the shared"batch"calculator.Testing
gpuma optimize --smiles <ibuprofen>with the default d4rev model oncuda:3returnedokandconverged: true. fairchem logs that it runs in a reduced-precision (TF32) mode; on these Turing GPUs that has no numerical effect.