Repository navigation
Prepare gpuma for packaging and publishing - #13
Conversation
- Improve mocks in `tests/conftest.py` to allow running tests without heavy dependencies (torch-sim, fairchem, etc.). - Fix `tests/test_models_module.py` to correctly handle monkeypatching of mocked modules. - Fix bug in `src/gpuma/optimizer.py` where `_load_calculator_impl` was missing. - Update `pyproject.toml` to use SPDX license expression string `license = "MIT"` and remove redundant License classifier, fixing build deprecation warnings and errors. - Enhance CI workflow in `.github/workflows/python-app.yml` to include build verification and twine check. Co-authored-by: niklashoelter <83964137+niklashoelter@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Prepared the codebase for packaging and publishing by:
conftest.pymocks (fortorch_sim,fairchem,ase,rdkit,morfeus) and fixingtest_models_module.pyandtest_mol_utils.pyfailures.src/gpuma/optimizer.pywhere the cached calculator loading function_load_calculator_implwas called but not defined.pyproject.tomlto uselicense = "MIT"(SPDX string) instead of the deprecated table format or redundant classifiers, ensuring compatibility with modernsetuptoolsbuild backend.pip install build twine,python -m build, andtwine checksteps to verify the package is buildable and metadata is correct.PR created automatically by Jules for task 10218344926544556189 started by @niklashoelter