Repository navigation
⚡ Optimize calculator caching with LRU eviction - #12
Conversation
- Replace `_CALCULATOR_CACHE` dict with `functools.lru_cache` on a helper function. - Limit cache size to 1 to prevent memory leaks with heavy ML models. - Add `tests/test_cache.py` to verify cache behavior. - Ensure Config object is reconstructed correctly for the loader. Co-authored-by: niklashoelter <83964137+niklashoelter@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Fix unused imports and import sorting in `tests/test_cache.py`. - Fix line length violation in `src/gpuma/io_handler.py`. - Verify fix with `ruff check`. Co-authored-by: niklashoelter <83964137+niklashoelter@users.noreply.github.com>
_CALCULATOR_CACHEdictionary withfunctools.lru_cache(maxsize=1).FAIRChemCalculatorinstances are memory-intensive (GPU/CPU), so keeping old instances is inefficient.tests/test_cache.pywhich verifies the bounded behavior and hit/miss stats. Confirmed existing tests pass.PR created automatically by Jules for task 9066723556091271429 started by @niklashoelter