Skip to content

Master-Client control#4867

Open
MilosKozak wants to merge 77 commits into
devfrom
ns_settings
Open

Master-Client control#4867
MilosKozak wants to merge 77 commits into
devfrom
ns_settings

Conversation

@MilosKozak

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented May 29, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 35.83039% with 1816 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.45%. Comparing base (74e8bad) to head (675548a).

Files with missing lines Patch % Lines
...kotlin/app/aaps/core/objects/wizard/BolusWizard.kt 13.36% 172 Missing and 3 partials ⚠️
.../kotlin/app/aaps/core/nssdk/NSAndroidClientImpl.kt 0.00% 169 Missing ⚠️
...ps/implementation/bolus/WizardBolusExecutorImpl.kt 34.87% 145 Missing and 10 partials ⚠️
...p/aaps/implementation/scenes/ActiveSceneManager.kt 10.49% 142 Missing and 3 partials ⚠️
...aps/plugins/automation/compose/AutomationScreen.kt 0.00% 103 Missing ⚠️
.../aaps/database/persistence/PersistenceLayerImpl.kt 0.00% 88 Missing and 2 partials ⚠️
.../kotlin/app/aaps/compose/navigation/AppNavGraph.kt 0.00% 88 Missing ⚠️
...ps/implementation/scenes/SceneAutomationApiImpl.kt 13.84% 56 Missing ⚠️
...guration/configBuilder/RunningConfigurationImpl.kt 26.47% 42 Missing and 8 partials ⚠️
...n/app/aaps/plugins/automation/AutomationRuntime.kt 57.52% 39 Missing and 9 partials ⚠️
... and 89 more
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #4867      +/-   ##
============================================
+ Coverage     32.01%   32.45%   +0.43%     
- Complexity    11175    11553     +378     
============================================
  Files          3048     3096      +48     
  Lines        193680   194895    +1215     
  Branches      21733    21805      +72     
============================================
+ Hits          62007    63245    +1238     
+ Misses       128054   127879     -175     
- Partials       3619     3771     +152     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

MilosKozak and others added 29 commits June 5, 2026 14:23
Migrate all 3 wizard eCarbs sites (scheduleECarbs, scheduleECarbsFromQuickWizard, scheduleECarbsFromQuickWizardCompose) to funnel their delivery branch through the shared deliverECarbs() instead of building their own DetailedBolusInfo + calling commandQueue.bolus directly. Record-only branches stay inline.

deliverECarbs gains a delayMinutes param and now sets eventType=CORRECTION_BOLUS + logs note + Minute(delay), making it a faithful superset of the wizard eCarbs UEL. eCarbs carry zero insulin so executeBolus's bolus mode-gate never fires.

commandQueue is now unused in BolusWizard - remove the constructor param, import, and the BolusWizardTest mock/arg.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant