Fix dead "Don't Kill My App?" link for unknown manufacturers

[PieterDeBruijn]

The About dialog built its target URL as
https://dontkillmyapp.com/<Build.MANUFACTURER>, which 404s for any manufacturer that does not have a dedicated page on dontkillmyapp.com (e.g. Fairphone, HMD, custom ROMs, emulator).

Link to the homepage with the ?app=AAPS query parameter instead, as recommended by DKMA's own API docs. The homepage lets the user pick their device and always resolves.

[MilosKozak]

I'm not sure if it's a win to make it more convenient to 5% of users and less convenient to 95%

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[MilosKozak]

sorry it's even worse because it offloads maintaining the list to me

[Philoul]

Hum, I agree with @MilosKozak, probably more than 95% of the users are with known brands (sorry for you...)

• Do we have an easy way to detect 404 error (before showing the target page to end user), and only show the generic page in this situation ? (if yes, it could be a way to keep direct page for > 95% of current users, and improve for the < 5% remaining ones)

[vanelsberg]

Do not like linking to the AAPS documentation as feels as RTFM... :-|

• Do we have an easy way to detect 404 error

Like @Philoul suggestion, if doable, technically I'd prefer checking for 404. However, this assumes user has an internet connection!

Other solution would be "whitelisting" <Build.MANUFACTURER>. If it is not in the list set <Build.MANUFACTURER> to "empty string" and link to the main page for user to decide?. Less coding but would take a bit more maintenance on the whitelist...?

Also Agree with @MilosKozak and I think there are other priorities currently.
That said:
Why making this more complex then needed:
Just link to the main site. User is perfectly capable to select his/her phone or go to general!?