Repository navigation
Use bloub 0.4.1 and remove the local bloub patch - #915
Merged
Merged
Conversation
bloub 0.4.1 has initialPhase in its source. The local dist patch read props.cycle in the component body, which caused 8 STRICT_READ_UNTRACKED warnings in dev. The maintainer publishes bloub, so it is excluded from minimumReleaseAge.
Contributor
NorbiAI Code ReviewReviewed commit: VerdictNo actionable findings in the full diff or inspected consumers; package behavior remains unverified because Resolved Since Previous ReviewNone. FindingsNo actionable findings. Withdrawn FindingsNone. Review details
|
Contributor
Transfer budget
Compared with the last green main CI run (CI run 36257033019). Updated for commit |
Contributor
Cloudflare previewUpdated for commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@norbert_bodziony/bloubfrom 0.3.0 to 0.4.1. TheinitialPhaseprop is now in the bloub source (feat: start a bot at a given time of its cycle (0.4.0) NorbertBodziony/bloub#3).patches/@norbert_bodziony%2Fbloub@0.3.0.patchand itspatchedDependenciesentry. The patch readprops.cyclein theBloubBotbody, which caused 8STRICT_READ_UNTRACKEDwarnings in dev.bunfig.toml: exclude only@norbert_bodziony/bloubfromminimumReleaseAge, because the maintainer publishes it.CONTRIBUTING.mdstates this exception.The
bun.lockintegrity for 0.4.1 is the same as the tarball that passed the bloub tests, typecheck and pack checks.Surfaces
Desktop renderer and public web (
AgentAvatarinpackages/ui),packages/brand, mobile (uses bloub data only). No IPC, migration or Team API change.Checks
packages/brand/src/bloub-avatar-motion.test.ts: 14 passed.AccountUpdateIsland.test.tsx: 6 passed, 0STRICT_READ_UNTRACKEDwarnings (8 before).bun run typecheck:renderer, Biome onpackage.json, and the pre-commit hook (check:staged,check:ui,typecheck) pass.Model and harness: Claude Opus 5.5, Claude Code.