fix: keep successful searches off stderr - #114
Conversation
|
Warning Review limit reached
Next review available in: 51 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughTransformer initialization now uses ChangesEmbedding initialization and diagnostics
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/embeddings.test.ts`:
- Around line 166-173: Update the test around the provider.embed calls to spy on
console.warn in addition to console.info, assert the warning spy was not called,
and restore both spies in the finally block while preserving the existing info
assertions.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 40242a88-26bd-4434-b0a7-755c810f2dc3
📒 Files selected for processing (6)
src/embeddings.tssrc/search.tssrc/update.tstests/embeddings.test.tstests/openbrain.test.tstests/update.test.ts
Summary
dtype: "auto"when loading the Transformers embedding pipelineRoot cause
The Transformers pipeline emitted a warning when
dtypewas omitted, while OpenBrain also used stderr for successful-search advisories and update notices. Hook consumers can treat stderr as a blocking failure signal, so successful operations need a clean error channel.Impact
Successful memory searches no longer produce stderr noise, making hook-backed integrations safe to build on without hiding genuine errors.
Validation
pnpm lintpnpm buildpnpm test— 130 passed, 1 opt-in integration test skippedFixes #88
Summary by CodeRabbit
Bug Fixes
Tests