fix: await y/N prompts so readline is not closed before input - #112
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe CLI now awaits ChangesCLI prompt handling
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
confirmUpdateandreadClaudeAutoMemoryPreferenceinsrc/cli.tsreturned theaskYesNopromise from inside atryblock withoutawait. Thefinallyblock then ranprompt.close()before the readline question could settle, so the[y/N]prompt printed but the process exited before the user could type an answer (Node reports an unsettled top-level await and exits with code 13).Adding
return awaitkeeps the readline interface open until the answer arrives, then closes it infinallyas intended.Why
Running
openbrain updateinteractively showedUpdate OpenBrain 0.7.1 -> 0.7.2? [y/N]and exited immediately with no chance to answer. The same defect exists in the Claude auto-memory prompt path, so both call sites are fixed.askBrainScopeandaskPathRulesalready await inside thetryblock and are unaffected.How it was tested
pnpm lint,pnpm build,pnpm testall pass (129 tests: 126 passed, 2 install-script tests only fail in an offline sandbox and pass with network access, 1 skipped).Summary by CodeRabbit