Skip to content

Prevent header NV allocation size overflow #547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
freedom-winds wants to merge 1 commit into
base: main
Choose a base branch
from
+12 −0
Open

Prevent header NV allocation size overflow #547

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions lib/nghttp3_frame.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,13 +149,25 @@ int nghttp3_nva_copy(nghttp3_nv **pnva, const nghttp3_nv *nva, size_t nvlen,
for (i = 0; i < nvlen; ++i) {
/* + 1 for null-termination */
if ((nva[i].flags & NGHTTP3_NV_FLAG_NO_COPY_NAME) == 0) {
if (nva[i].namelen == SIZE_MAX ||
buflen > SIZE_MAX - (nva[i].namelen + 1)) {
return NGHTTP3_ERR_INVALID_ARGUMENT;
}
buflen += nva[i].namelen + 1;
}
if ((nva[i].flags & NGHTTP3_NV_FLAG_NO_COPY_VALUE) == 0) {
if (nva[i].valuelen == SIZE_MAX ||
buflen > SIZE_MAX - (nva[i].valuelen + 1)) {
return NGHTTP3_ERR_INVALID_ARGUMENT;
}
buflen += nva[i].valuelen + 1;
}
}

if (nvlen > SIZE_MAX / sizeof(nghttp3_nv) ||
buflen > SIZE_MAX - sizeof(nghttp3_nv) * nvlen) {
return NGHTTP3_ERR_INVALID_ARGUMENT;
}
buflen += sizeof(nghttp3_nv) * nvlen;

*pnva = nghttp3_mem_malloc(mem, buflen);
Expand Down