Skip to content

Avoid duplicate signed char generic association with MSVC #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
crazywhalecc wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Avoid duplicate signed char generic association with MSVC #535

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3ecfeb3
Avoid duplicate signed char generic association with MSVC
crazywhalecc Jul 7, 2026
db9f39f
Limit MSVC generic workaround to affected versions
crazywhalecc Jul 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions lib/nghttp3_macro.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,13 @@ nghttp3_max_def(unsigned_int, unsigned int)
nghttp3_max_def(unsigned_short_int, unsigned short int)
nghttp3_max_def(unsigned_char, unsigned char)

#ifdef _MSC_VER
# define nghttp3_max_signed_char_assoc
#else /* !defined(_MSC_VER) */
# define nghttp3_max_signed_char_assoc \
signed char: nghttp3_max_signed_char,
#endif /* !defined(_MSC_VER) */
Comment thread
crazywhalecc marked this conversation as resolved.
Outdated

#define nghttp3_max(A, B) \
_Generic((A), \
long long int: nghttp3_max_long_long_int, \
Expand All @@ -77,15 +84,15 @@ nghttp3_max_def(unsigned_char, unsigned char)
long int: nghttp3_max_long_int, \
int: nghttp3_max_int, \
short int: nghttp3_max_short_int, \
signed char: nghttp3_max_signed_char, \
nghttp3_max_signed_char_assoc \
char: nghttp3_max_char, \
unsigned long long int: nghttp3_max_unsigned_long_long_int, \
unsigned long int: nghttp3_max_unsigned_long_int, \
unsigned int: nghttp3_max_unsigned_int, \
unsigned short int: nghttp3_max_unsigned_short_int, \
unsigned char: nghttp3_max_unsigned_char), \
short int: nghttp3_max_short_int, \
signed char: nghttp3_max_signed_char, \
nghttp3_max_signed_char_assoc \
char: nghttp3_max_char, \
unsigned long long int: nghttp3_max_unsigned_long_long_int, \
unsigned long int: nghttp3_max_unsigned_long_int, \
Expand All @@ -108,6 +115,13 @@ nghttp3_min_def(unsigned_int, unsigned int)
nghttp3_min_def(unsigned_short_int, unsigned short int)
nghttp3_min_def(unsigned_char, unsigned char)

#ifdef _MSC_VER
# define nghttp3_min_signed_char_assoc
#else /* !defined(_MSC_VER) */
# define nghttp3_min_signed_char_assoc \
signed char: nghttp3_min_signed_char,
#endif /* !defined(_MSC_VER) */
Comment thread
crazywhalecc marked this conversation as resolved.
Outdated

#define nghttp3_min(A, B) \
_Generic((A), \
long long int: nghttp3_min_long_long_int, \
Expand All @@ -117,15 +131,15 @@ nghttp3_min_def(unsigned_char, unsigned char)
long int: nghttp3_min_long_int, \
int: nghttp3_min_int, \
short int: nghttp3_min_short_int, \
signed char: nghttp3_min_signed_char, \
nghttp3_min_signed_char_assoc \
char: nghttp3_min_char, \
unsigned long long int: nghttp3_min_unsigned_long_long_int, \
unsigned long int: nghttp3_min_unsigned_long_int, \
unsigned int: nghttp3_min_unsigned_int, \
unsigned short int: nghttp3_min_unsigned_short_int, \
unsigned char: nghttp3_min_unsigned_char), \
short int: nghttp3_min_short_int, \
signed char: nghttp3_min_signed_char, \
nghttp3_min_signed_char_assoc \
char: nghttp3_min_char, \
unsigned long long int: nghttp3_min_unsigned_long_long_int, \
unsigned long int: nghttp3_min_unsigned_long_int, \
Expand Down