Open
Conversation
Switched to `sample2` for a more accurate and memory efficient option: https://bioinf.shenwei.me/seqkit/usage/#sample2
jfy133
reviewed
Apr 10, 2026
Member
jfy133
left a comment
There was a problem hiding this comment.
@bounlu I think this should instead be a separate module - it's an entirely new subcommand, and maybe have slightly different output (based on the description). IOt oculd be people are theoretically reliant on the original implementation, so that should stay as is.
This would be a relatively easy module to do though, you just copy over the existing module just adding 2 to every reference of teh sample subcommand/name
mashehu
requested changes
Apr 10, 2026
Contributor
mashehu
left a comment
There was a problem hiding this comment.
then this module needs to be called seqkit/sample2, i.e. a new module needs to be created for this
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switched to
sample2for a more accurate and memory efficient option: https://bioinf.shenwei.me/seqkit/usage/#sample2PR checklist
Closes #XXX
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda