Skip to content

Whatshap/phase: add pedigree input#11128

Draft
tetedange13 wants to merge 6 commits intonf-core:masterfrom
tetedange13:whatshap-phase-ped
Draft

Whatshap/phase: add pedigree input#11128
tetedange13 wants to merge 6 commits intonf-core:masterfrom
tetedange13:whatshap-phase-ped

Conversation

@tetedange13
Copy link
Copy Markdown
Contributor

@tetedange13 tetedange13 commented Apr 7, 2026

whatshap/phase can use a pedigree file to improve phasing

Relevant documentation : https://whatshap.readthedocs.io/en/latest/guide.html#phasing-pedigrees

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • Remove all TODO statements.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker NO DOCKER AVAILABLE
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda

@tetedange13 tetedange13 changed the title Whatshap: add pedigree input Whatshap/phase: add pedigree input Apr 7, 2026
@tetedange13 tetedange13 marked this pull request as draft April 7, 2026 13:57
Copy link
Copy Markdown
Contributor

@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does the pedigree file not change anything in the output ❓
But i think this is good to go :)

@tetedange13
Copy link
Copy Markdown
Contributor Author

tetedange13 commented Apr 8, 2026

How does the pedigree file not change anything in the output

I think (could not assert that from the code) that whatshap ignores pedigree when only 1 sample involved (which is the case in these tests)

I observed consistent behaviour locally with bigger dataset (100K variants)

@famosab
Copy link
Copy Markdown
Contributor

famosab commented Apr 9, 2026

Can you then add a test with multiple samples where the pedigree is not ignored? :)

@tetedange13
Copy link
Copy Markdown
Contributor Author

tetedange13 commented Apr 10, 2026

@famosab I can add such test, but after inspection I do not have all required data on nf-core/test-datatasets

Will have to add them first -> move current PR status to "draft"

@tetedange13 tetedange13 marked this pull request as draft April 10, 2026 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants