Whatshap/phase: add pedigree input#11128
Draft
tetedange13 wants to merge 6 commits intonf-core:masterfrom
Draft
Conversation
famosab
approved these changes
Apr 8, 2026
Contributor
famosab
left a comment
There was a problem hiding this comment.
How does the pedigree file not change anything in the output ❓
But i think this is good to go :)
Contributor
Author
I think (could not assert that from the code) that I observed consistent behaviour locally with bigger dataset (100K variants) |
Contributor
|
Can you then add a test with multiple samples where the pedigree is not ignored? :) |
Contributor
Author
|
@famosab I can add such test, but after inspection I do not have all required data on Will have to add them first -> move current PR status to "draft" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
whatshap/phasecan use a pedigree file to improve phasingRelevant documentation : https://whatshap.readthedocs.io/en/latest/guide.html#phasing-pedigrees
PR checklist
nf-core modules test <MODULE> --profile dockerNO DOCKER AVAILABLEnf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile conda