Skip to content

Make lineages_topology output optional in FREYJA_UPDATE#11124

Open
sam-baird wants to merge 4 commits intonf-core:masterfrom
sam-baird:freyja-optional-lineagesyml
Open

Make lineages_topology output optional in FREYJA_UPDATE#11124
sam-baird wants to merge 4 commits intonf-core:masterfrom
sam-baird:freyja-optional-lineagesyml

Conversation

@sam-baird
Copy link
Copy Markdown

Currently FREYJA_UPDATE will error with Missing output file(s) for pathogens without a lineages.yml file available in the Freyja-barcodes repo (for example RSV A). This lineage_topology output is not required for the downstream FREYJA_DEMIX process, so this PR just makes the output optional.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Broadcast software version numbers to topic: versions - See version_topics
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

@famosab
Copy link
Copy Markdown
Contributor

famosab commented Apr 8, 2026

Please join the nf-core organization on GitHub to enable the CI-tests to run on your PR. You can request to join the organization via #github-invitations in the nf-core slack. You can join the nf-core slack via https://nf-co.re/join.

Copy link
Copy Markdown
Contributor

@famosab famosab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sam-baird
Copy link
Copy Markdown
Author

Thanks, I submitted a request to join the organization on Slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants