Add one to each BED mask interval to work with corrected augur mask - #4
Add one to each BED mask interval to work with corrected augur mask#4huddlej wants to merge 1 commit into
Conversation
augur mask now reads in BED files following the standard expectation of a zero-indexed, half-open interval such that the last value in each interval is not included in the coordinates [1]. This commit updates the mask BED file for this build to decrement each interval's start by one to compensate this change in augur mask. [1] nextstrain/augur#512 (comment)
|
Ok, this took four attempts, but I think I've worked it out. The change here is simple but the reasoning involves annoying coordinate bookkeeping. Here is an example. In the original augur mask implementation the following BED file, was converted to 1-indexed positions The standard BED file format should read these coordinates into the 0-indexed positions To get the expected 1-indexed positions for vcftools from a BED file, we need to decrement the interval start by 1: This produces the 0-indexed positions of |
|
@huddlej @emmahodcroft Is this still relevant, or can this old PR be closed out? |
|
I defer to @emmahodcroft here, although this may eventually affect @kimandrews if she's tackling a TB build. |
augur mask now reads in BED files following the standard expectation of a
zero-indexed, half-open interval such that the last value in each interval is
not included in the coordinates [1]. This commit updates the mask BED file for
this build to increment each interval by one to compensate this change in augur
mask.
[1] nextstrain/augur#512 (comment)