Remove setAccessible call for MimePart property#45
Merged
Conversation
Remove accessibility setting for ReflectionProperty in MailPanel since it is no-op since php8.1
Member
|
thx |
This was referenced Apr 21, 2026
trejjam
added a commit
to trejjam/nextras-mail-panel
that referenced
this pull request
Apr 21, 2026
Wraps two unguarded ReflectionMethod::setAccessible(true) calls in PHP_VERSION_ID < 80100 checks: - src/FileMailer.php (Message::build()) - tests/MailPanelTest.phpt (MailPanel::getLatte()) The remaining call in src/MailPanel.php was already guarded correctly by nextras#45 and is left untouched. Preserves PHP 7.1-8.0 support per composer.json.
trejjam
added a commit
to trejjam/nextras-mail-panel
that referenced
this pull request
Apr 21, 2026
Wraps two unguarded ReflectionMethod::setAccessible(true) calls in PHP_VERSION_ID < 80100 checks: - src/FileMailer.php (Message::build()) - tests/MailPanelTest.phpt (MailPanel::getLatte()) The remaining call in src/MailPanel.php was already guarded correctly by nextras#45 and is left untouched. Preserves PHP 7.1-8.0 support per composer.json.
hrach
pushed a commit
that referenced
this pull request
Apr 21, 2026
Wraps two unguarded ReflectionMethod::setAccessible(true) calls in PHP_VERSION_ID < 80100 checks: - src/FileMailer.php (Message::build()) - tests/MailPanelTest.phpt (MailPanel::getLatte()) The remaining call in src/MailPanel.php was already guarded correctly by #45 and is left untouched. Preserves PHP 7.1-8.0 support per composer.json.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove accessibility setting for ReflectionProperty in MailPanel since it is no-op since php8.1