Fix resolution of -with-tower with TOWER_API_ENDPOINT#7045
Merged
pditommaso merged 1 commit intomasterfrom Apr 20, 2026
Merged
Conversation
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
✅ Deploy Preview for nextflow-docs-staging canceled.
|
Member
|
Which versions are affected by this issue? |
Member
Author
|
The linked issue confirmed in for 25.10 However, I think this has always been the behavior, since the |
pditommaso
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close #7044
Previously, the
ConfigBuilderassigned defaults for all of the-with-*CLI options. Now that these config settings are accessed through config classes likeTowerConfigandWaveConfig, default values should only be assigned there instead ofConfigBuilderThe report options like
-with-reportwere already corrected. This PR applies the same refactor to-with-towerand-with-wave