Skip to content

Fix resolution of -with-tower with TOWER_API_ENDPOINT#7045

Merged
pditommaso merged 1 commit intomasterfrom
fix-with-tower-endpoint-env-var
Apr 20, 2026
Merged

Fix resolution of -with-tower with TOWER_API_ENDPOINT#7045
pditommaso merged 1 commit intomasterfrom
fix-with-tower-endpoint-env-var

Conversation

@bentsherman
Copy link
Copy Markdown
Member

Close #7044

Previously, the ConfigBuilder assigned defaults for all of the -with-* CLI options. Now that these config settings are accessed through config classes like TowerConfig and WaveConfig, default values should only be assigned there instead of ConfigBuilder

The report options like -with-report were already corrected. This PR applies the same refactor to -with-tower and -with-wave

Signed-off-by: Ben Sherman <bentshermann@gmail.com>
@netlify
Copy link
Copy Markdown

netlify Bot commented Apr 17, 2026

Deploy Preview for nextflow-docs-staging canceled.

Name Link
🔨 Latest commit 79cfb80
🔍 Latest deploy log https://app.netlify.com/projects/nextflow-docs-staging/deploys/69e253e5bb05bb00084b070e

@pditommaso
Copy link
Copy Markdown
Member

Which versions are affected by this issue?

@bentsherman
Copy link
Copy Markdown
Member Author

The linked issue confirmed in for 25.10

However, I think this has always been the behavior, since the ConfigBuilder does not check the environment var when applying the default value. So I don't think it's a regression

@bentsherman bentsherman requested review from pditommaso and removed request for jorgee April 17, 2026 16:41
@pditommaso pditommaso merged commit ce962e8 into master Apr 20, 2026
24 of 25 checks passed
@pditommaso pditommaso deleted the fix-with-tower-endpoint-env-var branch April 20, 2026 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The TOWER_API_ENDPOINT environment variable is not used when running a pipeline with the -with-tower flag

2 participants