Add -user-secret and -workspace-secret flags to nextflow launch#7040
Merged
bentsherman merged 5 commits intonextflow-io:masterfrom Apr 28, 2026
Merged
Conversation
✅ Deploy Preview for nextflow-docs-staging ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Rashmi Naidu <rashmi.naidu@seqera.io>
Signed-off-by: Rashmi Naidu <rashmi.naidu@seqera.io>
f911e81 to
5324df4
Compare
ewels
approved these changes
Apr 17, 2026
Member
ewels
left a comment
There was a problem hiding this comment.
LGTM, though please add some docs :)
'cc @christopher-hakkaart for visibility.
Signed-off-by: Christopher Hakkaart <christopher.hakkaart@gmail.com>
Collaborator
|
@rnaidu-seqera - I've added some minimal docs. Can you please check for accuracy? |
rnaidu-seqera
commented
Apr 20, 2026
Contributor
Author
rnaidu-seqera
left a comment
There was a problem hiding this comment.
Looks great, thanks @christopher-hakkaart!
Signed-off-by: Ben Sherman <bentshermann@gmail.com>
bentsherman
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nextflow launchsubmits jobs to Seqera Platform via the/workflow/launchAPI but never includesuserSecretsorworkspaceSecretsin the request payload. As a result, Platform has no secrets to store in AWS Secrets Manager for the run, yet the Batch job environment always hasNXF_ENABLE_SECRETS=trueset — causing Nextflow to attempt and fail to fetch secrets that were never stored.This is inconsistent with a LaunchPad-initiated run, where the UI gathers secret selections from the user and includes them in the same API request. This bug was reported via the Support Team.
Changes
-user-secretand-workspace-secretCLI flags toCmdLaunch(can be specified multiple times, one secret name per flag)userSecretsandworkspaceSecretsfields toLaunchOptionsbuildLaunchRequestPayload()inLaunchCommandImplso they are included in the API request to PlatformUsage
Testing
Added two tests to
LaunchCommandImplTest.groovyin the existing Launch Request Building Tests section:should include workspace and user secrets in launch request— verifies that when-user-secret/-workspace-secretvalues are provided, they appear in the API payload as aSetshould not include secrets in launch request when none provided— verifies that when no secrets are specified, neither key appears in the payload at allRelated
Closes #7039